Treacherous Thunder v1.0

[defskull]

Comments and Rate is welcome :)

[.VTZ.]

FeedBack Leaks: (im not a pro trigger) Idea: original (5/5) Effects: poor lighting effects (1/5) Execution: nice arc effect (5/5) Config: very simple to configure (5/5) Tips: very useful to Gui/Mui newbies (5/5) ---------------------------------------- 0.0 to 5.5 Result: 5.2 ---------------------------------------- Really cool spell, +Rep

[defskull]

Thanks for the feedback :)

Although, I've got question on how to improve "Effects" ?
If you're reviewing something, you should include the "What's wrong" and "How to improve?", and you lack the "How to improve?"

Hope you tell me what to improve !
Thanks once again for the feedback, +rep :)

[Orcnet]

Nice Spell :)

[Marc Mamales]

Nice spell :D +Rep

[defskull]

Thanks guy for the support !

*I knew that Orcnet love Pony-related product!*

[Adiktuz]

from the screenie: isn't that lightning, a model by callahan?

anyway, spell is pretty cool and code looks fine on an overview. ^_^

I suggest changing those array variables to just different variables... as you only use few indexes...

[88WaRCraFT3]

epic +rep.

[defskull]

Adiktuz

I used this model from Tranquil: Great Lightning

If I use a different variable, same thing, it will increase the file size as variable increases
So, it's a win-lose situation lol

Thanks warcraft :)

[Adiktuz]

oh yeah, I always get confused between those models... anyway, put him on the credits... or better yet, just link the lightning model and remove it from the map...

For the arrays, its not about the file size, its about the performance... as arrays work slower than non-arrays... and since you only use about 1-3 indexes, its always better to just use diff variables...

arrays are only recommended if you have the chance of using a lot of the indexes...

[.VTZ.]

Effects ahh sure :) *you dont need to use custom lighting effects to get some cool lighting effects Mine example: Spell Setup Set SFX_Path[1]=Abilities\Spells\Orc\Purge\PurgeBuffTarget.mdl Set SFX_Path[2]=Abilities\Weapons\FarseerMissile\FarseerMissile.mdl Cast Special Effect - Create a Special Effect at point [1] using Abilities\Spells\Undead\DeathPact\DeathPactTarget.mdl Loop Special Effect - Create a Special Effect at point [1] using Abilities\Spells\Human\Thunderclap\ThunderClapCaster.mdl and Dummy Art - Model File Abilities\Spells\Orc\Purge\PurgeBuffTarget.mdl and Spell Art - Caster Abilities\Weapons\Bolt\BoltImpact.mdl Art - Animation name - Spell Art - Caster Attachment Point 1 - Weapon Art - Caster Attachment - 1 and when you use any custom model give credits to model creator ;)

About your lighting effects:

Image

That is mine own opinion, i'm just here to help
thats it!

[defskull]

Adiktuz

And I was thinking that I've arrived to the stage of "using many variable for same purpose"

Well, not gonna change the version for this spell, maybe it's for the next spell :)

VTZ

and when you use any custom model give credits to model creator ;)

I did.

Well, for me, I think that's just your personal opinion about the "Effect A (my effect) < Effect B (your effect)"
How can you be so sure that your SFX is more beautiful/appropriate than mine ?
Beauty cannot be measured.

EDIT:
Misunderstood the point lol
What I understand is, you ask me to use default effects rather than using custom ones, is it ?

[baassee]

Good to see you working with your coding skills still I have to point out a few flaws that the others seemed to miss.

-Should be map ini, it's not a multiboard

Time - Elapsed game time is 0.00 seconds

-All variables should be prefixed.

-Base variables and multiply variables are useless, just have one variable with the whole formula instead of wasting space on useless variables (yes they are useless as you can just have one instead of two, saving space (even if it's around a few bytes))

-These should be in some kind of formula like in the cast trigger

-------- [1] is for the fragment to appear for the first cast --------
Set FragmentOffset[1] = 200.00
-------- [2] is for the fragment's speed --------
Set FragmentOffset[2] = 15.00

-Applies with the same argument as above.

Set UnitInRange = 150.00

-SFX variables should be two non-arrayed variables instead of one arrayed as you are only using two array slots of 8192. Arrayed variables takes more space than two normal string variables.

-Basic I found out now in the cast trigger that you have loads of these arrayed variables. Make each of them non-arrayed and make more of the non-arrayed (yet as I said above not to have multiple variables, it doesn't apply to this as these are arrayed and you don't use enough index slots to make it worth it).

-Integer A should be switched into a custom integer variable, preferably prefixed.

-The Loop seems fine, just the setunitx/y calls are disturbing me for some reason. You're moving them to a point which you already called polar offset. And then you call GetLocX/Y to get their coordinates.

So as I'm lazy to explainit all, I'll keep it simple. Polar Offset BJ looks liek this:

Jass:

function PolarProjectionBJ takes location source, real dist, real angle returns location
    local real x = GetLocationX(source) + dist * Cos(angle * bj_DEGTORAD)
    local real y = GetLocationY(source) + dist * Sin(angle * bj_DEGTORAD)
    return Location(x, y)
endfunction

These points are those you are using:

Set Point[1] = (Position of Unit[1])
Set Point[2] = (Point[1] offset by FragmentOffset[2] towards Angles[1] degrees)

Your calls look like this:

Custom script: call SetUnitX(udg_Unit[1],GetLocationX(udg_Point[2]))
Custom script: call SetUnitY(udg_Unit[1],GetLocationY(udg_Point[2]))

And we know the BJ so let's fix this:

Custom script: call SetUnitX(udg_Unit[1],GetUnitX(udg_Unit[1]) + udg_FragmentOffset[2] * Cos(Angles[1] * bj_DEGTORAD))
Custom script: call SetUnitY(udg_Unit[1],GetUnitY(udg_Unit[1]) + udg_FragmentOffset[2] * Sin(Angles[1] * bj_DEGTORAD))

Unfortunatly you have this map check which checks the wrong point btw:

((Playable map area) contains Point[1]) Equal to True

Why should it check if the unit is in the map, it is before it's moved right? It's point2 you should check there.

So you probably cannot get rid of this stupid call but see this as a lesson for the future.

-No credit given to the author of the custom model?

Nice spell idea btw. Enjoy.

[defskull]

WHY DON'T ANYONE SEE THAT I CREDITED THE MODEL IN THE MA---....
Oh, on the first post ?
Will... Fix... That... (...and I was thinking that all people visit this spell, should download them, sorry for false thought) LOL