Swing Slash and Nether Glaive vBETA

[Moderator]

20:50, 10th Oct 2009
Dr Super Good:

The leak which TriggerHappy187 mentioned was preventing approval has been fixed thus this spell is now approved.
For a more detailed review or potentially better rating (I gave the bare minimum for a moderatly functional spell) I advise recontacting him.

 

[Weep]

One random comment: if you Swing Slash and immediately hold position, the Blademaster will be spinning until you give him another order.

 

[Shdow89]

One random comment: if you Swing Slash and immediately hold position, the Blademaster will be spinning until you give him another order.

Yes, I know I wanted so

 

[Shdow89]

Why are you guys so shy? Post some comments, I don't bite .

 

[Reaper2008]

How come you aren't using a scope?

 

[Shdow89]

How come you aren't using a scope?

I'm not using vJASS at all. It's JASS code .

 

[Weep]

Yes, I know I wanted so

Really? I find it hard to believe you intended it so that the Blademaster could be left spinning forever, even after the spell is done...

 

[Reaper2008]

I'm not using vJASS at all. It's JASS code .

Then explain constant function to me.

Constant is unavailable to vanilla JASS users.

EDIT: Just checked, and it works with functions.

Nice, didn't know that. You should, ofcourse, avoid using all these functions anyway, as they don't get inlined without JNPG.

 

[Shdow89]

Then explain constant function to me.

Constant is unavailable to vanilla JASS users.

EDIT: Just checked, and it works with functions.

Nice, didn't know that. You should, ofcourse, avoid using all these functions anyway, as they don't get inlined without JNPG.

What are you talking about? I should avoid constant function? How do you expect me to follow JESP standards if I don't use constant function? Constant function, were long before vJASS ever came...

 

[Reaper2008]

No, I mean I didn't know constant was useable without JNPG.

I know it's a JASS element, but only globals can be constant, and there's no JASS declaration for globals.

 

[Shdow89]

Really? I find it hard to believe you intended it so that the Blademaster could be left spinning forever, even after the spell is done...

There, I changed it. And you can't spin forever, because, I doubt someone will just stand in one place after casting a spell, if they die - it's reseted, if they move it's reseted, if they cast another spell, it's reseted. But now, I reseted to finish after nova's.... Hope you like it now

 

[Reaper2008]

Ah, just remembered, use better names for th abilities, i mean with the spell name in them, else it's hard to import them if you already got a spell with same globals/locals.

 

[Shdow89]

Ah, just remembered, use better names for th abilities, i mean with the spell name in them, else it's hard to import them if you already got a spell with same globals/locals.

I'm sorry I don't understand what you mean? Object Editor and Code name shares the same names?

 

[Reaper2008]

Lol, I failed. I meant variables.

 

[Weep]

But now, I reseted to finish after nova's.... Hope you like it now

Good, it's fixed.

 

[TriggerHappy]

Swing Slash

• All of your constant functions should be level-able.
• Your dynamically creating groups, just save a global group inside a hashtable in your init function and use a constant function to reference it.
  

  constant function slash_group takes nothing returns group
      return LoadGroupHandle(....)
  endfunction

• By using the above suggestion, you could also remove the udg_temp_group dependancy. Just use the same method.
• These are no needed at the end of your actions function;
  

      set b = null
      set g = null
      set ug = null

  They are already initialized as null. I'm talking about under the else block.

Nether Glaive

• Take the suggestions from swing slash, and use them here (dynamic groups, levelable constants ect..)
• In your filter_actions function you need to set local unit u = GetFilterUnit() to null.
• You need to add some bound safety when you set a units position to make sure they're inside the map (call SetUnitPosition(gl, newX, newY))

 

[Shdow89]

Swing Slash

• All of your constant functions should be level-able.
• Your dynamically creating groups, just save a global group inside a hashtable in your init function and use a constant function to reference it.
  

  constant function slash_group takes nothing returns group
      return LoadGroupHandle(....)
  endfunction

• By using the above suggestion, you could also remove the udg_temp_group dependancy. Just use the same method.
• These are no needed at the end of your actions function;
  

      set b = null
      set g = null
      set ug = null

  They are already initialized as null. I'm talking about under the else block.

Nether Glaive

• Take the suggestions from swing slash, and use them here (dynamic groups, levelable constants ect..)
• In your filter_actions function you need to set local unit u = GetFilterUnit() to null.
• You need to add some bound safety when you set a units position to make sure they're inside the map (call SetUnitPosition(gl, newX, newY))

Thank you, finally go some suggestions on how to improve.
Ok, let's see:
1. I can't make them all level-able, I don't really see the point in here.
2. Ok, will try this with a group. But how will that remove udg_temp_group dependency when I still need to make a global group, and name it?
3. oops for null xD. I just c'n'p them from the upper code. Removed!

For Nether Glaive:

2. Ok, will set it to null, thx.
3. I thought actually I don't need pathing settings for this one. It targets an enemy unit and a caster, since they can't go outside the map bounds, that means the glaive won't either, so that's really unnecessary.

Thank you for your comment!

 

[TriggerHappy]

1. I didn't mean literally all of them, the ones like AOE and so on.
2. Nevermind, cause then you would just have a hashtable dependency.

 

[Shdow89]

Also forgot to mention:
- Removed leaks (u = null in Action Function in Nether Glaive)

 

[Shdow89]

The leak which TriggerHappy187 mentioned was preventing approval has been fixed thus this spell is now approved.
For a more detailed review or potentially better rating (I gave the bare minimum for a moderatly functional spell) I advise recontacting him.

And so I did. Thank you.