Sweeping Beam - v0.1

[Moderator]

09:52, 23rd Oct 2010
The_Reborn_Devil:

The triggering looks ok. Nice to see some SC2 stuff here ^^


Status: Approved
Rating: Recommended

 

[Blueman127]

I like it but

I like the spell but! To me it seems like lvl 1 and lvl 4 do same damage. And i can't also not see where the damage is upgradet for each lvl.?

 

[Noobsmoke]

looks preety good. Ill test it later

 

[baassee]

Some points.

-(Life of u) Greater than 0.00 don't use, use boolean comparison IsUnitDead equals to false (IsUnitType(u, UNIT_TYPE_DEAD) as it's more accurate and also GetUnitState/GetWidgetLife is used with 0.405, not 0.

-udg_g never gets destroyed and if you want to use this as a ENUM group, please clear it afterwards as it now stores units and more and more and more.

-Special Effect - Create a special effect at zLoc using Abilities\Weapons\AncientProtectorMissile\AncientProtectorMissile.mdl

Should be stored in a string variable (as some ppl might not want a knockback effect)-

Anyways this is good, just went threw the code, keep up the good work!

 

[D4RK_G4ND4LF]

-(Life of u) Greater than 0.00 don't use, use boolean comparison IsUnitDead equals to false (IsUnitType(u, UNIT_TYPE_DEAD) as it's more accurate and also GetUnitState/GetWidgetLife is used with 0.405, not 0.

acording to this source http://www.mappedia.de/wiki/Jass:IsUnitDeadBJ the GUI IsUnitDeadBJ is the same (and IsUnitAliveBJ calls not IsUnitDeadBJ wtf)
and I am not healing any dead units anyway

-udg_g never gets destroyed and if you want to use this as a ENUM group, please clear it afterwards as it now stores units and more and more and more.

GroupEnumUnitsInRange automatically clears the group

-Special Effect - Create a special effect at zLoc using Abilities\Weapons\AncientProtectorMissile\AncientProtectorMissile.mdl

Should be stored in a string variable (as some ppl might not want a knockback effect)-

I won't add 3 lines of code and another variable just to make 1 string to be set somewhere else

Anyways this is good, just went threw the code, keep up the good work!

thanks

 

[baassee]

acording to this source http://www.mappedia.de/wiki/Jass:IsUnitDeadBJ the GUI IsUnitDeadBJ is the same (and IsUnitAliveBJ calls not IsUnitDeadBJ wtf)
and I am not healing any dead units anyway

GroupEnumUnitsInRange automatically clears the group

Now that is awkward as it is true ! Weird BJs

Oh didn't knew that :O

 

[Titania]

Eye lazor O--- O--- *beep beep beep* +rep

 

[Maker]

I'd like to see some effect at the point where the laser hits the ground, now the laser just ends abruptly.

You could create dummy units and attach effects to them and move the units wit the laser. Maybe Serpent ward missile effect could be good.

 

[Gekigengar]

The lightning is actually moving "To" the caster, instead of moving out of the caster. it looks weird only in that point.xD

 

[88WaRCraFT3]

Sweeettt Realy awesome :d +REP

 

[purged]

Nice one! Looks very good

 

[Nightmare Moon]

I love this spell. Just for my map. Thanks a lot. +rep

 

[NoMoreChallenge]

How to adjust the damage per level? I can only change the base damage.

 

[D4RK_G4ND4LF]

How to adjust the damage per level? I can only change the base damage.

set damage = something + something_else * convert integer to real(level of ability being cast for triggering unit)

 

[Mainy]

If the caster walk after cast looks wierd

 

[Nightmare Moon]

I have a problem with this spell, when i cast it sometimes the lightning effects don't show.
I can assure you that i didn't change ANYTHING!
Anyone has this problem too??

 

[baassee]

Anyone has this problem too??

I re-tested it and the answer is no.

 

[NoMoreChallenge]

I have a problem with this spell, when i cast it sometimes the lightning effects don't show.
I can assure you that i didn't change ANYTHING!
Anyone has this problem too??

same here

When I cast it on original map it's ok, but after I imported it to my map it's not ok.
Maybe I have to check the triggers again.

 

[baassee]

Check that any other triggers don't use any variables of this. Check the ability condition (although it wont corrupt the lightning), check the documentation and follow it threw, make sure everything is alright.

 

[Soul-_-Hunter]

Eye lazor O--- O--- *beep beep beep* +rep LOL your eyes crossing like X ?

 

[Titania]

Eye lazor O--- O--- *beep beep beep* +rep LOL your eyes crossing like X ?

X??What do you mean by that

 

[88WaRCraFT3]

NomoreChallenge : "When I cast it on original map it's ok, but after I imported it to my map it's not ok.
Maybe I have to check the triggers again."

Your problem is, that you need to copy ALL variables.
Some of them are putted by the script, so when you copy the triggers, variable doesn't comes. You can put all variables in your map by this :
All variables that this spell uses, put them, and set them however you want, copy that trigger, in a map, and you will have that variables, after that, import the spell, but remove the trigger before that you have created.

 

[Kam]

I copied all variables and it still does not appear all of the time. I then copied my adjusted triggers back to your test map and it all worked fine.

 

[Kam]

*bump

The above is still an issue. There is something map specific that is causing a problem.

 

[Noobsmoke]

File -> Preferences -> General -> and check "Automaticlly create unknown variables ..."

 

[Kam]

All variables are present.

 

[Freedom.Dream]

How do you make the mini video at the description?

 

[Talesman]

very good! max reputation

 

[Kam]

For anyone have a graphical display issue:

http://www.hiveworkshop.com/forums/world-editor-help-zone-98/lightning-effect-display-bug-248689/

 

[Razwerd]

I can't make this spell deal damage, everything else works fine but deals 0 dmg.

 

[Pyrogasm]

Are you sure the units you're trying to damage aren't causing any of the following checks (used in the spell right before damaging) to fail?

• 
  (Life of u2) Greater than 0.00
• 
  (u2 is A structure) Equal to False
• 
  (u2 is A flying unit) Equal to False
• 
  (u2 is Mechanical) Equal to False
• 
  (u2 is Magic Immune) Equal to False
• 
  (u2 is in Sweep_Group[i]) Equal to False
• 
  (u2 belongs to an enemy of (Owner of u)) Equal to True

 

[Razwerd]

Yep I checked those conditions, doesn't seem to be the problem. I also checked variables, they're exactly the same as the test map.

Unit - Cause u to damage u2, dealing Sweep_Data[((i x Sweep_DataCount) + 11)] damage of attack type Spells and damage type Unknown

Anything might cause it in this line? Everything seems okay

 

[Pyrogasm]

Perhaps you have set armor values differently in your map. Use Damage type normal. Put debug messages "Game - Display..." before and after the damage line to print things like damage amount, name of target unit, etc. You'll figure out what's running and what's not.

 

[Razwerd]

I did that and I noticed that it deals damage on first cast but not on others, used text to show that too. Why would the trigger only work once?

 

[Pyrogasm]

I just downloaded the map and it works fine for me (I changed something and saved it to recompile it too). Try deleting all of its variables and reimporting the spell. If I had to guess, some of the spell's default variable names are so generic that you've already used them for something else in your map.

 

[Razwerd]

I indeed checked variables because I had some with the same name and reimported, didn't seem a variable issue. I'll rey reimport the spell or sth...