[SpellPack]- Elemental SpellPack v1.06c

redscores · 09-01-2008, 07:16 PM

Last Created unit leaks always, simply use a variable and clean the variable afterwards. set the variable to no unit.

And there were many 2nd places, because we all had 24 points.

redscores · 09-02-2008, 02:48 PM

I already said that in the comment... please read what i write thanks.

Zack1996 · 09-11-2008, 01:22 PM

Lol, didn't read it and too lazy to update it till now. I made the orb look better and other visuals are improved. Now you can't really see the wisp in the middle.

Hanky · 10-13-2008, 08:37 PM

Good spell idea and also the spell itself is ok. I see no leaks so far. The only thing that bother me is that the spell isn't MUI or at least MPI.

But else the spell is well made. Especially I liked the tooltip which is very detailed. So far I can give you a 3.5/5!

Zack1996 · 10-14-2008, 10:05 AM

The spell is MUI -_-
You can try and spam it or get another caster or something and it will still work properly.
If you find any bugs reguarding MUI or MPI problems, please tell me :D.
Thanks for the review, +reps :)

Hanky · 10-14-2008, 10:44 AM

Really? Then I have to check it a second time. Maybe my eyes had a driver error.

Edit: Ups, yes you are right your spell seems to be MUI.

Bobo_The_Kodo · 10-16-2008, 03:08 AM

Last created unit doesn't leak... it's a global

xxdingo93xx · 10-17-2008, 02:13 PM

Idea/Creativity: 7/10
Coding: 10/10
Balance: 10/10
Ability Tooltip: 10/10
MUI: Yes (+2/10)
(Yes: +2/10, No: -2/10, MPI: +/-0/10)
Language: GUI: (+/- 0/10)
(GUI: +/- 0/10, Jass: +1/10, vJass: +2/10)
Total: 39/40

Average: 9/10 = 4/5

Viewers Note:

Hey man, a nice idea. There are leaking water spells everywhere so nice that you invented some.
Your coding style is good too, all leaks are removed.
Poor it is made in GUI >.< would look so good in Jass!!!
Your ability tooltip is excellent. The balancing of the ability too.

TheBlooddancer · 10-17-2008, 10:46 PM

@ The water wave.
Set its life span to 8 seconds or so, much better effect.
At its current, it doesnt really matter where it ware, it vanish after 2 sec. anyways.

By using 8 the wave will be REALLY big, at the end, but you can fix that by changing its scaling value, and add a "Mana of (Temp Unit)/2" to your scaling trigger.

Good Luck, triggering.

Zack1996 · 10-18-2008, 01:52 PM

Thanks for the encouragement and for looking at my spell :D. I will update it with some changes and add more water spells soon : ).
I was thinking maybe a whirlpool that really looks like one as in the units twirl around or something.
PS: I agree that water spells are lacking in the spells section.
EDIT: My spell doesn't seem to move to the top when I update. Also, the update date is not updated :P

Need_O2 · 10-19-2008, 10:41 PM

Quote:

Originally Posted by redscores

Last Created unit leaks always, simply use a variable and clean the variable afterwards. set the variable to no unit.

go learn something noob

Zack1996 · 10-20-2008, 02:36 AM

Last created unit doesn't leak? Ok, but I'm too lazy to change anything for now.
Also, please keep on topic about the spell and stop arguing with redscore (Yes, I know redscore is annoying sometimes).
I am planning to add a whirlpool skill, just not sure when though.

Need_O2 · 10-20-2008, 11:40 AM

Your pack is just fine nothing bad about it (leaks or bugs)
keep going

Dark_Dragon · 10-22-2008, 12:59 PM

Really impressive nice coding, spells and no leaks found. You use the bj_wantDestroyGroup which many people don't even think about, and it leaks much more then locations so as you use it you destroy this group and leaves no leaks. I give you 8/10. And btw nice GUI skills.