Rune System

[Moderator]

20:51, 29th Aug 2009
hvo-busterkomo: The system could definitely be uselful although the coding is somewhat lacking in areas (what is with the module?).

 

[xxdingo93xx]

Why do you implement functions which actually don't do anything? That makes no sense for me xD
and why do you define the MAX_RUNES as textmacro? I guess there is a sensefully reason you did it like this ... but could you explain this to me?
I also don't really get the

static key STRUCT

 

[YourNameHere]

If you want anything to happen, you can specify the functions to do something.
I tried defining it as a global, but JassHelper somehow said it would be a wrong size definition then. So I had to do it that way. :/
And they key is just for my own purpose. I use it instead of writing

StringHash( "Struct" )

everytime. I could just insert 0 there, but it's more understandable this way.

 

[Yixx]

Looks like a nice system, though i got 2 little problems with it:
1) You never null any local handles.

2)

method add takes integer rune returns nothing
    set .Runecount = .Runecount + 1
    if HaveSavedInteger(Hash, rune, this) then
        debug call BJDebugMsg("Error: Adding an same item twice is not possible!")
        return
    endif
    set .Items[.Runecount] = rune
    call SaveInteger(Hash, rune, this, .Runecount)
endmethod

What if the item is already in the struct? You return under the if. But you already increased .Runecount!!
Increase .Runecount under the endif, not above the if.

 

[YourNameHere]

1) Yeah, right. Fixed.

2) Might have overseen that. Thanks for the info. Fixed, too.

 

[Deuterium]

Ok I'll test this later... but as an advice, don't use methods for system calls... I mean, alot of GUIers who might want to use this have no idea of what vJass is. And even for beginner Jassers, they won't know how structs work.

So instead of having Runes.create(), make a function CreateRune() which calls the method.

Ok, it might VERY SLIGHTLY decrease efficiency, but really, would it matter?

 

[Yixx]

Depending on the current JASSHELPERS inlining performance, the call should be inlined. And as the thing is in vJass, Jasshelper is needed to import the system. So it might even NOT decrease the efficiency. But i dont know how well Jasshelper inlines currently

 

[Deuterium]

This is no rune systems like DotA's... :s it does totally different thing, and they're not even runes...

 

[YourNameHere]

Oh wow, just because I used items instead.
Ofcourse you have to create the runes yourself. It just places an item at an random rect if there isn't already one existing. And that's the same it does in DotA, right?

 

[Deuterium]

Oh oops... hehe sorry i might have wide triggering knowledge but almost zero object editing knowledge... apologies

 

[YourNameHere]

No problem, atleast I hope you've got it now

 

[Deuterium]

Yupp I did... yet, try working on the idea i mentioned in one of my previous posts, it takes only few minutes

 

[YourNameHere]

Updated.

 

[cHeRoL]

Nice system.
I have created a similar system months ago,and it is GUI.

 

[Fundo!]

uhm where do you input the runes and the regions?


private constant integer ITEM_ID = rune ??

 

[Arnadath]

Also i say youd better ask location not rect for the rune creation point

 

[YourNameHere]

I'd never ever use locations. I'd rather use coordinates but they'd be as innefficient as rects are in this case. It's just easier to use coordinates, most people (including me) are just too lazy to place some rects

 

[PurplePoot]

This code would be way cleaner and way too short for approval if you just replaced all that complicated crap with an itempool. Hell, for the rects you could use the recently made intpool by me (partially) and Dusk (mostly).

 

[Camper9514094]

oo i beginner