Model v3

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

IcemanBo: I just can repeat at first what Magtheridon96 said: Indent properly. Read http://www.hiveworkshop.com/forums/...80/jpag-jass-proper-application-guide-204383/

20:21, 2nd Mar 2014
Magtheridon96: Man, this is garbage.

LocationHolder should not be a thing in there. Please don't pollute this thing with Quasi classes, that's the root of all evil. And unmaintainable projects. And anus? FECES? Really now?

I think you should make Quaternion and other mathematical objects resources on their own in the JASS section.

And for the love of Jesus fucking Christ, INDENT THE CODE PROPERLY. I SAY THIS WITH CAPS BECAUSE I'M THE MODERATOR WHO HAS BEEN REVIEWING ONE OF YOUR SYSTEMS WITH UNINDENTED CODE AND TELLING YOU TO INDENT FOR OVER A YEAR BACK IN THE 2012-2013 PERIOD. JESUS CHRIST MAN. JUST... JESUS FUCKING CHRIST.

Okay, now that that's out, I can continue calmly.

You need to restructure the system. You're providing people with the ability to make their own models in-game dynamically. Therefore, just give them a Model struct and a ModelSpecification struct or something like that. A ModelSpecification struct just stores vertex and face data. A Model has a ModelSpecification and an array of lightnings (use a Table for this) to represent a physical model. No other structs needed for the user to use. Make everything that the user should not use private. Encapsulation is fucking important man.

Your documentation could be improved too. You could "rly" fix the grammatical errors and spelling mistakes. "rly" man, "rly".

 

[gorillabull]

                

 

[BPower]

Based on newly added relies this seems like a problem of my engine.
The demo map dropped my fps to ~1!!!!!

Concerning the accuracy of real numbers like -0.0000011504, you should take a look into this discussion: Complex Numbers

 

[Kazeon]

I don't say this offensively
What can I use this for?

 

[Rheiko]

this is... awesome...

 

[Malhorne]

By god indent pls !
I'll re read this after the indentation

 

[gorillabull]

The demo map dropped my fps to ~1!!!!!

Concerning the accuracy of real numbers like -0.0000011504, you should take a look into this discussion: Complex Numbers

well im kinda curious why the lag happens too, the gpu does this same thing and more maybe hundreds of times a minute without a problem yet when done this way it causes heavy lag must be the real operations being converted to strings or w/e the value u mentioned can be a string or even an integer, not much precision would be lost, but it uses numbers like this because i created this sphere in gmax and replaced some of the other values in notepad, i didnt bother shortening the numbers as they are quite a lot

 

[Almia]

Gorillabull, it has been so many months since we and the other moderators talked about your indentation. For the last time : FIX YOUR INDENTION!

 

[Arhowk]

What normal application does this have?

 

[TriggerHappy]

struct Objectcan easily collide with other peoples structs. I personally would privatize (unless it's meant to be accessed) or rename it.

 

[gorillabull]

I don't say this offensively
What can I use this for?

What normal application does this have?

i dunno i got bored and i made it

well actually since you can generate wireframe and rotate it however you want this can be used in places where models normally are since you can rotate the wireframe x/y/z wise on the fly, for models you have to preset their yaw and pitch

 

[Arhowk]

i dunno i got bored and i made it

well actually since you can generate wireframe and rotate it however you want this can be used in places where models normally are since you can rotate the wireframe x/y/z wise on the fly, for models you have to preset their yaw and pitch

Please don't upload it here if it has no application whatsoever. . .

 

[Adiktuz]

I've been spending minutes looking at this thing, and I still fail at determining what practical use it has... To me this far exceeds the mind-boggling experience I had from some of Nestharus' resources...

 

[looking_for_help]

Why is there a discussion about the usefulness of this? It can be used for spell effects, so it has a clear application. You can also build other shapes with different colours so its basically a spell effect generator.

I like it, however the code should be made a bit cleaner (indentation etc.)

 

[gorillabull]

i was actually thinking of making a platform system and make the platform out of this.. u know so u dont have to import any special units

 

[Arhowk]

Why is there a discussion about the usefulness of this? It can be used for spell effects, so it has a clear application. You can also build other shapes with different colours so its basically a spell effect generator.

I like it, however the code should be made a bit cleaner (indentation etc.)

According to previous commenters it drops your framerate to 1fps...

It also only supports a max of 200 tris and requires static vertex positions

 

[BPower]

Beautiful what math is capable of, but I don't see any practical utility for this resource.

What really bothers me is that you literally have no API.
Porper identation and outlined comments would be nice aswell, so normal people understand what is actually going on inside the code.

Edit: Based on newly added relies this seems like a problem of my engine.
For now I consider your submission as some sort of "wc3 ingame art" and I tend to instant reject it, because of framerate it causes.
However it seems to work and out of respect of the required skills to create such a piece of code, I'll just leave the thread. Maybe Maker or Purge have a different opinion.

Good luck

 

[looking_for_help]

According to previous commenters it drops your framerate to 1fps...

Yes, but that are technical problems which should be fixed of course. Apart from that it could be useful for creating dynamically morphing effects.

 

[Adiktuz]

There is a discussion about it's usefulness because even the one who made it didn't even tell us (or maybe he didn't realized) on how this can be used for practical purposes...

a system for generating simple model wireframe inside wc3

and as long as it drops you to 1fps or so, it won't be usable... it might be "useful" theoretically, but not usable...

Plus he didn't even defined what those parameters are for...

 

[gorillabull]

ok.. i ll explain what everything does and make it more extensive since no one understands it

 

[Strikest]

This looks cool, you can use this to make unique effects in your map. For me my framerate did not drop at all, so it does have a practical application for spell effects. For example that green lightning sphere in the demo map could totally be a spell projectile/effect. Plus all that math is so beautifully headache inducing! xD

 

[looking_for_help]

For me the framerate stayed at constantly 60 fps too. The frame drops should be investigated, but I guess as long as not too much objects are used (like with every spell) it should be fine.

 

[gorillabull]

^ yes

 

[BPower]

Seems like I was the bug here. I've edited my comments.

 

[Kazeon]

this is quite cool actually.. 5/5 from me
please gimme an example how to form a peasant model with this system.. thnks..

 

[gorillabull]

thats actually the first thing i tried doing ^^ however like i said you cant make such complex models (well u can generate them but you cant do anything else with them not even move them ) because of operation limit thing so if u generated a peasant it would just be standing there doing nothing

 

[Magtheridon96]

I think becoming the mean moderator with attitude issues is rewarding~

Also, add an in-game screenshot of the peasant model made out of a custom lightning model. That would look epic.

 

[Wrda]

Beautiful what math is capable of, but I don't see any practical utility for this resource.

What really bothers me is that you literally have no API.
Porper identation and outlined comments would be nice aswell, so normal people understand what is actually going on inside the code.

Good luck

There is a discussion about it's usefulness because even the one who made it didn't even tell us (or maybe he didn't realized) on how this can be used for practical purposes...

and as long as it drops you to 1fps or so, it won't be usable... it might be "useful" theoretically, but not usable...

Plus he didn't even defined what those parameters are for...

^ I totally agree.

thats actually the first thing i tried doing ^^ however like i said you cant make such complex models (well u can generate them but you cant do anything else with them not even move them ) because of operation limit thing so if u generated a peasant it would just be standing there doing nothing

For some reason there is wc3 model editor, or such other external systems. No offense, but I don't see how can this be useful (or better, appliable) for users...maybe it was a waste of time.

 

[Tal'Rarity]

I'd use this if you made a GUI interface to it, looks extremely useful. It's funny how people think this is useless when DGUI was amazing.

Good job on it gorillabull, how many objects until lag though?

 

[Vortigon]

this commenting made my day
"recalc errythang"

 

[Tal'Rarity]

There is barely even a jass interface to allow for configuration at all, I do suggest making it easier to use your system and maybe provide some GUI support.

What I meant is so users of your system can easily change values to match and make any shape they want without requiring much knowledge of math. Maybe like 5-7 examples of shapes such as a sphere like you already got, a cube, a prism.

 

[Kazeon]

I think this belongs to The Lab

Nice idea by the way, me neither, I can see how this can be useful, at least fun

 

[gorillabull]

There is barely even a jass interface to allow for configuration at all, I do suggest making it easier to use your system and maybe provide some GUI support.

What I meant is so users of your system can easily change values to match and make any shape they want without requiring much knowledge of math. Maybe like 5-7 examples of shapes such as a sphere like you already got, a cube, a prism.

yea i will provide gui support as well as include other simple models

 

[Almia]

Still a garbage.

Can you give a practical use of this? Also, afaik, lightning effects are limited in numbers.

 

[Lender]

1. can be useful

2. IMO most people who would use this system won't be able since it is too complex and hard to configure

3. ceep it up and this could be a nice system but for now its only a 2/5 for me.

 

[Chaosy]

holy shit. I will try to use this right naow.

 

[Trigger.edge]

how many models you have designed with this system?

 

[Faith]

I'm sorry but this is trash.. I'm not even decent with JASS and I know how badly your code is written. Conventions yo. Grammar is always a plus too.

If you could make significant improvements to these areas I would be able to provide constructive feedback regarding the spell.

No offensive implications intended.

 

[Almia]

Faith is correct. I don't see any use of this UNLESS this can read .mdx files and load the wireframe as a lightning wireframe. That would be awesome.

 

[gorillabull]

thats a good idea x) i dont know why i didnt think about that. though will have to stick to mdl files binary files will be too much work

 

[PAZBoy]

Yeah, but how does it work?