11:28, 29th Jul 2012
Magtheridon96: 4/5. This is a pretty neat spell.
Like I said in the first review, you could use the values of the coordinate variables you're setting directly inside the AddLightningEx call. callAddLightningEx(udg_KR_LModel,true,GetUnitX(...),GetUnitY(...),GetUnitFlyHeight(...),GetUnitX(...),GetUnitY(...),GetUnitFlyHeight(...))
Other than that, good job, there doesn't seem to be any major issues. You still need to fix the above issues though. Only then would it be approved.
Spells that use hashtables in general aren't properly useable when it comes to the same unit casting the spell multiple times.
That is what indexing is for.
Apheraz Lucent and -Grendel will forever live in my memory, two extraordinary persons taken away from our world before their time.
And so i dedicate my signature to them, a small sign of memory that will forever remain on my profile, for as long as it exists.
I am sad it's all i can do for them now and i hope i never did something to bring them anything but joy in their life.
World is a cruel place, but it was a better place with both of you in it. Miss you both.
Set KR_Distance = (Distance between KR_CasterLoc and KR_PickedLoc)
The variable "KR_CasterLoc" doesn't exist in the trigger "KR_Loop", so it's just the middle of the map.
On a related note: that's a shitton of variables.
The X/Y-variables don't carry over to other maps (because the editor doesn't copy variables that are only used in JASS - or am I mistaken?) and they can just as well be removed entirely.
I always go by the rule of thumb that you never need more than 3 temporary locations, but you're using 6 of them.
Edit: there's more! You should take the Location Z into account as well, because I just had the problem that my terrain z was about -700 and the lightning effects were completely off.
Don't worry, you've got all the locations you need :D. You do need to keep the 2 Z-variables though, otherwise the custom script will be too long.
This is what I did to fix it:
(You can use "bj_lastCreatedLightning in your spell as well). Endedit
(also, I want people to start using the variable "GlobalHashtable" for all spells/systems and use a "HashtableId" which is an integer like 'KiR' - may upgrade it to 4 digits though
I do accept that it's just a silly dream and it will probably never happen, but a man can have dreams!)
Last edited by ap0calypse; 01-03-2013 at 05:59 PM.
Reason: Some edits