Holy Dragging Spell v1.05

[Axarion]

Looks nice, nice idea good documentation customizable... 5/5

Edit: Why is rating not possible?

[-Berz-]

Originally Posted by Axarion

Edit: Why is rating not possible?

What? -.-

[Slaydon]

yes, its not a rate system or somth anymore, looks interesting btw;D

Wut, after posting this it came back

[D4RK_G4ND4LF]

it is either not MUI or bugged
sometimes I cast it without anything happening

edit:
hashtables
of cause it's bugged
and 4 triggers for a channel spell....
you could check if the order is == channel and merge the other trigger somehow (usually every spell is possible with 2 triggers but sometimes 3 are easier)

however all the other stuff seems to be good
you remove leaks
LOTS of documentation
new idea
ingame screenshot


you don't have to make it with indexing but fix the bug mentioned on top
(gl finding it)
I just don't like hashtables

[Maker]

Originally Posted by D4RK_G4ND4LF

it is either not MUI or bugged
sometimes I cast it without anything happening

After testing a bit, I coudn't make it bug. Could you tell when it bugs for you? I'll try to test some more.

hashtables of cause it's bugged
and 4 triggers for a channel spell....
you could check if the order is == channel and merge the other trigger somehow (usually every spell is possible with 2 triggers but sometimes 3 are easier)

I've never had anything bug due to it being made with hashtables, and I've done a lot of spells. Don't let your bias cloud your vision.

The first trigger fires when the spell is cast, it is needed.
The second trigger takes care of dragging units in, it's needed.
The third trigger adds units entering the area into unit group of units being dragged. It also creates special effects. The time interval of trigger #3 is much greater than the interval of trigger #2 (0,25 s vs 0,03 s). It's actually better to divide these into two different trigger, to make the spell require less CPU time.
The fourth trigger just cancels the spell. Can't do without it.

To me it sounds like you don't know what you're talking about. The number of triggers by itself doesn't make a spell any better/worse.

Saying "OMG it haz 4 trigggers, make it less" isn't worth anything. If you can give some advice and/or idea how to actually squezze it in three triggers without compromizing performance too much, I'm all ears.

I thank you for taking the time to have a look at the spell.

[D4RK_G4ND4LF]

20 edits later....

you still forgot about the bug:

[Shdow89]

Well I like the spell, effects are good, and executed well. Though I really don't like GUI, 'cause of 1000 of variables and triggers.

I would just give one comment on how to improve:

- Try using SetUnitX(whichUnit, newX) and SetUnitY(whichUnit, newY) instead using Unit - Move Instantly. It's really simple to use and units (ofc. if the speed is reasonable) can still move and be dragged (pulled), and it doesn't reset their commands. Not to mention it looks nicer :P.

Anyway my rating for this spell would be 4/5. :)

[Revolve]

Again, thanks alot :D You really executed it well :3

[reason 3]

Awesome spell,i like it a lot.5/5 from me!
Nice work as usual Maker

[Maker]

Originally Posted by D4RK_G4ND4LF

put that

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

(Holy_Dragging_Spell_Lightning is empty) Equal to True

Then - Actions

Trigger - Turn off (This trigger)

Else - Actions

to the end of the trigger
so it will be executed only once and have the same effect

Now it gets executed as many times as there are units in the group. It only gets executed when a unit is removed form the group. 6 units in a group -> executed 6 times per spell cast.

If it is at the end of the trigger, it gets executed 1/(0.03)*6=200 times per spell cast. This is for the "group trigger". For the other trigger, it is one time per spell cast as it is now, or 1/(0.25)*6=24 times per spell cast.

So no, I won't put it at the end of the trigger.

your variable names are weird
sometimes you call the HDS_ and sometimes Holy_Dragging_Spell_
Typo: Holy_Daragging_Spell_Group

All HDS_something are what you can configure. But yeah, I guess they could all begin with HDS_

the hotkey is wrong
you wrote Q but it is B

Thanks for pointing that out.

...check if the order of the caster is equal to channel and

That would be slower solution than what it is now. There's absolutely no need to squeeze it in three triggers, unless there's some performance gain to be had by doing so.

if random integer between x and y equal to x

What do you mean by that? What do I need to randomize?

-hashtables are SLOW
-arrays are FAST

In my eyes hashtables are fast enough.

-making the same unit be able to cast a spell more then once at a runtime is much easier with arrays...

Yeah, but this spell is meant to have longer cooldown than it's duration is. Otherwise it would be way overpowered.

Thanks for your comments

Originally Posted by Shdow89

- Try using SetUnitX(whichUnit, newX) and SetUnitY(whichUnit, newY) instead using Unit - Move Instantly.

Thanks, I will look into it.

========================================================================

Update:

v1.01
Using SetUnitX and SetUnitY instead of Move unit instantly. The spell now constantly pulls, which is cool.
Hotkey fixed.
Set pull speed to customizeable variable.

That SetUnitX/Y tip was golden. Awesome really. +rep coming your way.

[Maiaencore]

can i use this on my map??.

=]

+credits

[Maker]

As long as you give credits, you're free to use it in your map :)

[Atami]

Hi,

spell looks realy nice, but i found a big bug.
If you set the spell point out of the map, in the black area around the map, the moving units, going to be bugged. please fix it!
BTW. nice idea.

Looks nice ()
Good Coding ()
Mui ()
Some Bugs ()
Easy to Customize ()

So my rate is >> 4/5 <<

enjoy

[Maker]

Thanks for noticing that.

Updated:

v1.02
Fixed location leak.
Fixed child hashtable clearing bug.
Added pathing walkability check when moving units.