Moderator
M
Moderator
BPower: Once again I've wrote a review for you system ( link ), so you can adjust your code in your own map.
I don't get the feeling that this develops towards approval, not even close.
Furthermore we have many high quality resources in our database,
which cover 2D and 3D unit motion.
BPower: I wrote a few questions into the comments.
Removed the rating I gave in the last review.
Otherwise refer to my old review.
13:47, 19th Feb 2016
BPower: Feature bloated code abomination.
I rather recommend using one of the approved well structured
knockback systems from our database.
13:51, 3th Feb 2016
BPower: Set back to Need Fix until [self=http://www.hiveworkshop.com/forums/spells-569/gui-knockback-3d-jump-system-beta-v1-0-a-269237/#post2783284] you wrote a changelog[/self]
10:00, 6th Oct 2015
Bribe:
Pros
+ Has a lot of features
Cons
- Pauses the unit being knocked back and there is no configurable to change this
- Pathing check is done with an item, so any unit with collision size greater than 16 can get stuck
- Paladon's deprecated Knockback had a better implementation of. knockback
- Uses unit groups and hashtables, making it extremely slow (knockbacks need to be as fast as possible and this is among the slowest)
Recommendation
? Build your stuff on top of one of the many approved knockback systems.
20.01.2016, BPower:
I say it directly. I don't see a chance for approval for this system. Only with a radical change in code.
Reasons:
I don't get the feeling that this develops towards approval, not even close.
Furthermore we have many high quality resources in our database,
which cover 2D and 3D unit motion.
BPower: I wrote a few questions into the comments.
Removed the rating I gave in the last review.
Otherwise refer to my old review.
13:47, 19th Feb 2016
BPower: Feature bloated code abomination.
I rather recommend using one of the approved well structured
knockback systems from our database.
13:51, 3th Feb 2016
BPower: Set back to Need Fix until [self=http://www.hiveworkshop.com/forums/spells-569/gui-knockback-3d-jump-system-beta-v1-0-a-269237/#post2783284] you wrote a changelog[/self]
10:00, 6th Oct 2015
Bribe:
Pros
+ Has a lot of features
Cons
- Pauses the unit being knocked back and there is no configurable to change this
- Pathing check is done with an item, so any unit with collision size greater than 16 can get stuck
- Paladon's deprecated Knockback had a better implementation of. knockback
- Uses unit groups and hashtables, making it extremely slow (knockbacks need to be as fast as possible and this is among the slowest)
Recommendation
? Build your stuff on top of one of the many approved knockback systems.
20.01.2016, BPower:
I say it directly. I don't see a chance for approval for this system. Only with a radical change in code.
Reasons:
- Knockback / Missile systems must be fast, hence FroGroup + hashtable is a very bad choice.
--- - Unit groups lose units which are removed, therefore you have high potential for leaks.
--- - I found handles leaks in your code ( group and location )
--- - Couldn't find where you flush a childkey in the hashtable.
--- - The API is terrible. A user shouldn't save into a hashtable. Instead he / she assigns globals and the system transfers them to the table internally.
---