Decoy v1.1 by iamdl

[Moderator]

12th Dec 2015
IcemanBo: For long time as NeedsFix. Rejected.

IcemanBo: http://www.hiveworkshop.com/forums/spells-569/decoy-v1-1-iamdl-256319/#post2638143

Old

12:13, 5th Jan 2015
IcemanBo:
http://www.hiveworkshop.com/forums/...256319/?prev=r=20&status=p&page=5#post2635978

 

[iamdl]

Reserved!!

http://www.hiveworkshop.com/forums/spells-569/decoy-v1-1-iamdl-256319/#post2636500

 

[Justicebringer]

I like it!

 

[GywGod133]

Trigger Loop

Set DecoyDummyLoc[DecoyIndex] = (Position of DecoyDummy[DecoyIndex2])
change into this
Set DecoyDummyLoc[DecoyIndex2] = (Position of DecoyDummy[DecoyIndex2])

In Unit Group
you must save the Picked Unit in a variable

Objects\Spawnmodels\Other\ToonBoom\ToonBoom.mdl
maybe you must save it in variable also

 

[iamdl]

Trigger Loop

Set DecoyDummyLoc[DecoyIndex] = (Position of DecoyDummy[DecoyIndex2])
change into this
Set DecoyDummyLoc[DecoyIndex2] = (Position of DecoyDummy[DecoyIndex2])

In Unit Group
you must save the Picked Unit in a variable

Objects\Spawnmodels\Other\ToonBoom\ToonBoom.mdl
maybe you must save it in variable also

thx for the review

 

[nhocklanhox6]

The spell itself is simple but really cool, I like it .

But I give you some of my suggestion, hope it useful for you ^^.

First: Create a configurables trigger or maybe explain your spell config .

You need to find another way to avoid the damage twice on enemy units instead of using DecoyAddGroup because it can not be synchronized with the other caster, just imagine, if the caster A and B casting ability at the same time and when the time is up, caster A will cause damage to the enemy, but B is not, because that unit were added in DecoyAddGroup variable!.

• Set DecoyCaster[DecoyIndex2] = DecoyCaster[DecoyIndex]
  • Set DecoyCasterLoc[DecoyIndex2] = DecoyCasterLoc[DecoyIndex]
  • Set DecoyDummy[DecoyIndex2] = DecoyDummy[DecoyIndex]
  • Set DecoyDummyLoc[DecoyIndex2] = DecoyDummyLoc[DecoyIndex]
  • Set DecoyDummyDuration[DecoyIndex2] = DecoyDummyDuration[DecoyIndex]
  • Set DecoyGroup[DecoyIndex2] = DecoyGroup[DecoyIndex]
  • Set DecoyAoE[DecoyIndex2] = DecoyAoE[DecoyIndex]
  • Set DecoyDummySpinTime[DecoyIndex2] = DecoyDummySpinTime[DecoyIndex]
  • Set DecoyDummyFadeout[DecoyIndex2] = DecoyDummyFadeout[DecoyIndex]
  • Set DecoyDamage[DecoyIndex2] = DecoyDamage[DecoyIndex]
  • Set DecoyIndex2 = (DecoyIndex2 - 1)
  • Set DecoyIndex = (DecoyIndex - 1)

This can save your life :

onCast..

• Decoy
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Wind Walk
  • Actions
    • -------- -----Instance a new Index----- --------
    • Set DecoyMUI = (DecoyMUI + 1)
    • -------- ..Save it.. --------
    • Set Decoy_MUI[DecoyMUI] = DecoyMUI

onLoop..

• Decoy Loop
  • Events
    • Time - Every 0.03 seconds of game time
  • Conditions
  • Actions
    • For each (Integer DecoyMUI) from 1 to DecoyIndex, do (Actions)
      • Loop - Actions
        • -------- ..Load instance.. --------
        • Set DecoyData = Decoy_MUI[DecoyMUI]
        • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
          • If - Conditions
          • Then - Actions
            • -------- ..Simply recycle it!.. --------
            • Set Decoy_MUI[DecoyData] = Decoy_MUI[DecoyMUI]
            • -------- For safer :) --------
            • Set Decoy_MUI[DecoyMUI] = -1
            • -------- Simply deindex --------
            • Set DecoyMUI = (DecoyMUI - 1)
            • -------- ----------------------------- --------
            • If (All Conditions are True) then do (Then Actions) else do (Else Actions)
              • If - Conditions
                • DecoyData Equal to 0
              • Then - Actions
                • Trigger - Turn off (This trigger)
              • Else - Actions
          • Else - Actions

save Owner of DecoyCaster[DecoyIndex] to variable since it's used in period trigger.

Save damage type and attack type as configurable parts.

And as AKA.GywGod133 said .

Suggestion: So, the fake blade master will stand still and spin?, that would be boring and easily to realize it's fake. You have to think a cool stuff to go with it like A blade master "can" attack the enemy or something like that?.

Well, just it!. That's just my personal review. Fix or not depending on you , but keep it in mind: do NOT trying to fix my words like some "rude" people in here .

 

[IcemanBo]

• Add a configuration trigger for the user, and make the levels to be configurable. Make as much configurable as possible.
• Create a seperate spell in object editor, and rename it. Currently it's still "Windwalk".
• Your damaging operations are linked with deindex part, and not with the spinning animation/time. That doesn't make sense.
• Your FadeOut doesn't make sense. Just let it end if timer < 0.
• There is no need to make your point variable an array.
• There is no need to make DecoyGroup variable an array.
• DecoyAddGroup is not needed.
• You only remove the location if you deindex. Else you it leaks.

Just a suggestion: I would rename "DecoyIndex" into "DecoyMaxIndex" and "DecoyIndex2" into "DecoyIndex" or something like "DecoyInt/Integer". It will be simpler to read.

These should be enough changes for next update. Contact me for questions.

 

[iamdl]

~updated

 

[IcemanBo]

v1.0 Initial release
v1.1 Configuration added and delete useless variable

^If I look at code, I can see you made more changes. It's not funny to read whole code again after each update.

So please make/keep a clean and good changelog, if you make further updates.

Now to spell:

- Attack- Damage type should be cinfigurable.
- Deindex if dummy is dead.
- No need to play the spin animation and making damage in case the dummy is dead. Makes no sense.
- It would only make sense to make damage while spinning. Not on deindex.
- The loop leaks.

Needs Fix

 

[Ralle]

This is an english-only site.