Death Grip v1.6a

[D4RK_G4ND4LF]

nice but not perfect yet
(bug was produced with 0 sec spell cd, casting time of 0 and shiftclick)

better use coordinates only
stuff you need for that:
a global location which is created at map ini to check terrain height
call MoveLocation(udg_zLoc, udg_x, udg_y)
set udg_z = GetLocationZ(udg_zLoc)
call MoveLightningEx(udg_lightning, true, udg_x, udg_y, udg_z, udg_x2, udg_y2, udg_z2)
call SetUnitX(udg_u, udg_x)

changing flying height with a speed of 0 is instant

don't use arrays for temporary data storage
they are slower and unnecessary

you are using this line twice
why are you using it anyway?

Unit - Order DG_Caster[DG_Integer[3]] to Attack DG_Target[DG_Integer[3]]

all in all I'd vote it 2/5 now cause it is bugged and the idea is poor, as well as the execution
(however it is far better than some other submissions and has potential)
for indexing I'd suggest you to read this [GUI] Dynamic Indexing Template
and also add something unique

[Bluebay]

Originally Posted by Bluebay

you are using this line twice
why are you using it anyway?

This line is not used twice and the spell is a reference to the WoW one. It taunts the ennemy and force you and him to attack each other.

As for the other things, I'll check it tonight.
Thanks for commenting.

[EDIT] I fixed all the bugs except for the last things you told me
"don't use arrays for temporary data storage
they are slower and unnecessary".
I didn't really understand what was the real problem with it, because you are linking me a tutorial with a similar system.

Check the new "Versions" /hidden windows to see all the changes in the description.

[Klingo]

I CANT POST THE TRIGGERS because I've got the French editor. If anyone could post it, please do it !

Triggers

Init

Death Grip cast

Events

Unit - A unit Starts the effect of an ability

Conditions

(Ability being cast) Equal to Death Grip

Actions

-------- ---------- COMMENTS ---------- --------
-------- Please, check the READ ME before starting reading the trigger comments. --------
-------- XX Add one more caster XX --------
Set DG_Integer[1] = (DG_Integer[1] + 1)
-------- XX Set the caster XX --------
Set DG_Caster[DG_Integer[1]] = (Casting unit)
-------- XX Set the target XX --------
Set DG_Target[DG_Integer[1]] = (Target unit of ability being cast)
-------- << Set the attached effect during the flying effect (must have no animations to work) >> --------
Special Effect - Create a special effect attached to the chest of DG_Target[DG_Integer[1]] using Abilities\Spells\Undead\DeathCoil\DeathCoilSpecialArt.mdl
Special Effect - Destroy (Last created special effect)
-------- << Set the final effect of Death Grip on the target >> --------
Set DG_FinalEffect[DG_Integer[1]] = Abilities\Spells\Items\AIil\AIilTarget.mdl
-------- << Add high to the lightning effect from on caster (0.00 will make the lightning touching the ground) >> --------
Set DG_AddZCaster[DG_Integer[1]] = 50.00
-------- << Add high to the lightning effect on the target (0.00 will make the lightning touching the ground) >> --------
Set DG_AddZTarget[DG_Integer[1]] = 50.00
-------- XX Set the locations XX --------
Set DG_TempPoint1 = (Position of DG_Caster[DG_Integer[1]])
Set DG_TempPoint2 = (Position of DG_Target[DG_Integer[1]])
Set DG_TempPoint3 = (DG_TempPoint1 offset by 150.00 towards (Angle from DG_TempPoint1 to DG_TempPoint2) degrees)
-------- XX Set the angle between the final destination and the first location of the target XX --------
Set DG_AngleFacing[DG_Integer[1]] = (Angle from DG_TempPoint1 to DG_TempPoint2)
-------- XX Set the distance between the final destination and the first location of the target XX --------
Set DG_DistanceTotal[DG_Integer[1]] = (Distance between DG_TempPoint2 and DG_TempPoint3)
-------- XX Set the distance left to the total distance XX --------
Set DG_DistanceLeft[DG_Integer[1]] = DG_DistanceTotal[DG_Integer[1]]
-------- XX Set the level XX --------
Set DG_Level[DG_Integer[1]] = (Level of (Ability being cast) for DG_Caster[DG_Integer[1]])
-------- << Set the damages >> --------
Set DG_Damages[DG_Integer[1]] = (((Real(DG_Level[DG_Integer[1]])) x 0.15) x DG_DistanceTotal[DG_Integer[1]])
-------- << Set the speed of the grip effect >> --------
Set DG_Speed[DG_Integer[1]] = 25.00
-------- << Set the arc of the grip effect >> --------
Set DG_HighArc[DG_Integer[1]] = 0.55
-------- XX Compile the total distance with the high arc to form the high settings XX --------
Set DG_HighSettings[DG_Integer[1]] = (DG_DistanceTotal[DG_Integer[1]] x DG_HighArc[DG_Integer[1]])
-------- << IMPORTANT : Make sure that the spell here matches with the Stun dummy ability >> --------
Set DG_StunAbility[DG_Integer[1]] = Stun
-------- << Set the lightning effect >> --------
Lightning - Create a Finger of Death lightning effect from source DG_TempPoint3 to target DG_TempPoint2
Set DG_Lightning[DG_Integer[1]] = (Last created lightning effect)
-------- XX Reset the action for bolean condition in loop XX --------
Set DG_FinishAction[DG_Integer[1]] = False
-------- XX Check to autorize the high changes of the Target XX --------
Unit - Add Forme de corbeau to DG_Target[DG_Integer[1]]
Unit - Remove Forme de corbeau from DG_Target[DG_Integer[1]]
-------- XX Stop collision of the target with ground objects XX --------
Unit - Turn collision for DG_Target[DG_Integer[1]] Off
-------- XX Removing Locations XX --------
Custom script: call RemoveLocation(udg_DG_TempPoint1)
Custom script: call RemoveLocation(udg_DG_TempPoint2)
Custom script: call RemoveLocation(udg_DG_TempPoint3)
-------- XXXXXXXXXXXXXXXXXXXXXXX --------
If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DG_Integer[2] Equal to 0

Then - Actions

Trigger - Turn on Death Grip loop <gen>

Else - Actions

Set DG_Integer[2] = (DG_Integer[2] + 1)

periodic

Death Grip loop

Events

Time - Every 0.03 seconds of game time

Conditions
Actions

For each (Integer DG_Integer[3]) from 1 to DG_Integer[1], do (Actions)

Loop - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DG_FinishAction[DG_Integer[3]] Equal to False

Then - Actions

If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DG_DistanceLeft[DG_Integer[3]] Greater than 0.00

Then - Actions

Set DG_DistanceLeft[DG_Integer[3]] = (DG_DistanceLeft[DG_Integer[3]] - DG_Speed[DG_Integer[3]])
Set DG_TempPoint1 = (Position of DG_Caster[DG_Integer[3]])
Set DG_TempPoint2 = (DG_TempPoint1 offset by 150.00 towards DG_AngleFacing[DG_Integer[3]] degrees)
Set DG_TempPoint3 = (DG_TempPoint2 offset by DG_DistanceLeft[DG_Integer[3]] towards DG_AngleFacing[DG_Integer[3]] degrees)
Unit - Move DG_Target[DG_Integer[3]] instantly to DG_TempPoint3
Set DG_RealTimer[DG_Integer[3]] = (DG_RealTimer[DG_Integer[3]] + (180.00 / (DG_DistanceTotal[DG_Integer[3]] / DG_Speed[DG_Integer[3]])))
Set DG_High[DG_Integer[3]] = ((Sin(DG_RealTimer[DG_Integer[3]])) x DG_HighSettings[DG_Integer[3]])
Animation - Change DG_Target[DG_Integer[3]] flying height to DG_High[DG_Integer[3]] at 0.00
Lightning - Move DG_Lightning[DG_Integer[3]] to source DG_TempPoint3 and target DG_TempPoint1
Custom script: set udg_DG_x[udg_DG_Integer[3]] = GetUnitX(udg_DG_Target[udg_DG_Integer[3]])
Custom script: set udg_DG_y[udg_DG_Integer[3]] = GetUnitY(udg_DG_Target[udg_DG_Integer[3]])
Set DG_zLoc = (Position of DG_Target[DG_Integer[3]])
Custom script: set udg_DG_z[udg_DG_Integer[3]] = GetLocationZ(udg_DG_zLoc)
Set DG_z[DG_Integer[3]] = (DG_z[DG_Integer[3]] + (DG_High[DG_Integer[3]] + DG_AddZTarget[DG_Integer[3]]))
Custom script: call RemoveLocation(udg_DG_zLoc)
Custom script: set udg_DG_x2[udg_DG_Integer[3]] = GetUnitX(udg_DG_Caster[udg_DG_Integer[3]])
Custom script: set udg_DG_y2[udg_DG_Integer[3]] = GetUnitY(udg_DG_Caster[udg_DG_Integer[3]])
Set DG_zLoc = (Position of DG_Caster[DG_Integer[3]])
Custom script: set udg_DG_z2[udg_DG_Integer[3]] = GetLocationZ(udg_DG_zLoc)
Set DG_z2[DG_Integer[3]] = (DG_z2[DG_Integer[3]] + ((Current flying height of DG_Caster[DG_Integer[3]]) + DG_AddZCaster[DG_Integer[3]]))
Custom script: call RemoveLocation(udg_DG_zLoc)
Custom script: call MoveLightningEx(udg_DG_Lightning[udg_DG_Integer[3]], true, udg_DG_x2[udg_DG_Integer[3]], udg_DG_y2[udg_DG_Integer[3]], udg_DG_z2[udg_DG_Integer[3]], udg_DG_x[udg_DG_Integer[3]], udg_DG_y[udg_DG_Integer[3]], udg_DG_z[udg_DG_Integer[3]])
Custom script: call RemoveLocation(udg_DG_TempPoint1)
Custom script: call RemoveLocation(udg_DG_TempPoint2)
Custom script: call RemoveLocation(udg_DG_TempPoint3)

Else - Actions

Set DG_RealTimer[DG_Integer[3]] = 0.00
Set DG_TempPoint1 = (Position of DG_Target[DG_Integer[3]])
Special Effect - Create a special effect at DG_TempPoint1 using DG_FinalEffect[DG_Integer[3]]
Special Effect - Destroy (Last created special effect)
Unit - Create 1 Dummy Stun for (Owner of DG_Caster[DG_Integer[3]]) at DG_TempPoint1 facing Default building facing degrees
Unit - Set level of Stun for (Last created unit) to DG_Level[DG_Integer[3]]
Unit - Order (Last created unit) to Neutral - Firebolt DG_Target[DG_Integer[3]]
Unit - Add a 2.00 second Generic expiration timer to (Last created unit)
Lightning - Destroy DG_Lightning[DG_Integer[3]]
Unit - Turn collision for DG_Target[DG_Integer[3]] On
Unit - Order DG_Target[DG_Integer[3]] to Attack DG_Caster[DG_Integer[3]]
Unit - Cause DG_Caster[DG_Integer[3]] to damage DG_Target[DG_Integer[3]], dealing DG_Damages[DG_Integer[3]] damage of attack type Spells and damage type Magic
Set DG_FinishAction[DG_Integer[3]] = True
Custom script: call RemoveLocation(udg_DG_TempPoint1)
Set DG_Integer[2] = (DG_Integer[2] - 1)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DG_Integer[2] Equal to 0

Then - Actions

Set DG_Integer[1] = 0
Trigger - Turn off (This trigger)

Else - Actions

Else - Actions

Enjoy it

[Wezthal]

I noticed something that can cause problems in multiplayer.
Here's a screenshot: (look at the dark ranger)

[Bluebay]

Originally Posted by Wezthal

I noticed something that can cause problems in multiplayer.

Yes, the only solution to this is to make the distance between the caster and the target closer at the end of the cast. I will add it to the setting possibilities, in the cast trigger (0.00 would fix the problem, but would make it weird).

[GoblinShoD]

Hm, I found a problem. Not sure if it was caused by me, or if it is something in the triggers. Got a "Script Errors" window with these errors. All in Death Grip Loop:

Error Messages

set udg_DG_x[udg_DG_Integer[3]] = GetUnitX(udg_DG_Target[udg_DG_Integer[3]])

set udg_DG_y[udg_DG_Integer[3]] = GetUnitY(udg_DG_Target[udg_DG_Integer[3]])

set udg_DG_x2[udg_DG_Integer[3]] = GetUnitX(udg_DG_Caster[udg_DG_Integer[3]])

set udg_DG_y2[udg_DG_Integer[3]] = GetUnitY(udg_DG_Caster[udg_DG_Integer[3]])

call MoveLightningEx(udg_DG_Lightning[udg_DG_Integer[3]], true, udg_DG_x2[udg_DG_Integer[3]], udg_DG_y2[udg_DG_Integer[3]], udg_DG_z2[udg_DG_Integer[3]], udg_DG_x[udg_DG_Integer[3]], udg_DG_y[udg_DG_Integer[3]], udg_DG_z[udg_DG_Integer[3]])

Don't know if anyone knows how to fix it, but it would be great.

EDIT: Tried to copy the triggers again but without success, got the same script errors.

[Bluebay]

It doesn't seems to be a problem for me. However, I fixed alot problems with the "MoveLightningEx" function that caused the same problem.
Check if you have got the last patch from Battle.net and tell me if it works.

[GoblinShoD]

Originally Posted by Bluebay

It doesn't seems to be a problem for me. However, I fixed alot problems with the "MoveLightningEx" function that caused the same problem.
Check if you have got the last patch from Battle.net and tell me if it works.

I'm pretty sure I dont got the latest patch. I'm currently using a school computer without administrator rights, due to our school policy, so I cant download new updates on it (my own laptop burned up :P). Is there a way to work around it even if I dont got the new update? :/

[MortAr]

Why would you add a taunt effect when the target is stunned before it?

// 1,000th post

[Bluebay]

Originally Posted by GoblinShoD

I'm pretty sure I dont got the latest patch. I'm currently using a school computer without administrator rights, due to our school policy, so I cant download new updates on it (my own laptop burned up :P). Is there a way to work around it even if I dont got the new update? :/

Oh I see... But I don't really think you can, sorry :/
Without the new patches, I guess you can play only a few of the maps uploaded on the Hive...

Originally Posted by MortAr-

Why would you add a taunt effect when the target is stunned before it?

The stun effect is just something I randomly added, I will as soon as I can add a setting so you can disable it.

EDIT : Fixed.

Originally Posted by MortAr-

// 1,000th post

Gratz

--------------

Thanks for commenting everyone

[War_Golum]

nice anyways, i think are well done

[Berb]

I don't think I missed anything, though GUI is not friendly to my eyes.

Originally Posted by Review

Death Grip

There are a few calculations that could be improved to anticipate various changes to a unit's 3D position throughout the game. If the target unit is hovering then it should not be pulled to the ground and then lifted towards the caster. I would also recommend using some kind of prevention mechanism to stop the spell from being casted on the same unit twice.

It would be outstanding if you could weight multiple casts on the same unit such that if two casters were on the opposite sides of the target then the target would be elevated but not actually move in any particular way, or for 2+ instances on the same target for that matter.

- There's a glitch when the unit is being pulled by a caster that is on a different cliff-level, it seems to be a result of buggy height-control. Here's a screen-shot:



The peasant was pulled from two levels down, and was pulled to an awkward height and ultimately placed in the cliff. Even if you perhaps want this type of functionality you should still fix the height problems.

I think this has something to do with it:

Set DG_RealTimer[DG_Integer[3]] = (DG_RealTimer[DG_Integer[3]] + (180.00 / (DG_DistanceTotal[DG_Integer[3]] /
DG_Speed[DG_Integer[3]])))
Set DG_High[DG_Integer[3]] = ((Sin(DG_RealTimer[DG_Integer[3]])) x DG_HighSettings[DG_Integer[3]])
Animation - Change DG_Target[DG_Integer[3]] flying height to DG_High[DG_Integer[3]] at 0.00

I don't see anywhere here where you anticipate any change in height. I think it would be an improvement among other things if you were to implement some sort of calculation that incorporates the height difference.

- Why do you use "DG_Integer[3]" as your loop index? There is no reason to have to refer to an array each time you want to reference this value when you could just as easily use "bj_forLoopAIndex" or the "For Loop Integer A" as it is named in GUI.

- You fail to reset the fly-height of the target unit once it is no longer used. If you've got a unit that hovers (or a flying unit, but I see you've unchecked it in the available targets) it will not reset the fly-height and the hovering unit will be permanently lower to the ground (or until something else resets its fly-height).

- I know that the available targets does not include Flying units, but I think it would be beneficial to the spell if you allowed the user to determine this, and included functionality for these situations in your calculations.

- The values for "Cast Backswing" and "Cast Point" are not 0.00 in your "Dummy Stun" caster unit. This causes the stun to be slightly delayed after the target unit has already been pulled to the caster.

In addition to this, the *speed* of your "Stun" ability is set to 10000, though setting it to 0 will yield an spell that instantly applies the effect to the target.

When you deduct from "DG_DistanceLeft" you need to check "immediately" whether or not the distance is less than 0. If it is, then create your dummy unit there and issue it to stun the target so that there is absolutely no delay in between when the target reaches its destination and when it is stunned.

If you apply all the details I've mentioned above you can also replace the expiration timer on the dummy-caster with a "Unit - Remove" call and just remove it immediately.

I didn't include this in the review, but you have an unused variable named "DG_Group". I'm assuming this is just remnants of previous trials which is why I didn't want it to reflect in my review.

[Bluebay]

Ok, I'm trying to fix everything possible.
Thanks for this nice review dude !

About the unused variable, the previous check of the condition in the loop trigger was checking if the caster was already in the global caster group, instead of the current boolean "DG_FinishAction". I'll remove it right now.

[Magtheridon96]

Wow, an update after so long :p
Well, I'm going to review this as soon as I have access to a World Editor... and electricity :| (At home)