Crave Mana v. 1.04

[Deuterium]

Deuterium's Brief Review

Crave Mana v. 1.01

1. This:

(Life of (Picked unit)) Greater than 0.46

Should be:

(Life of (Picked unit)) Greater than 0.41

2. Adjust the damage and special effects to occur once per enemy unit instead of having it occurring at 0.03 intervals and thus decreasing efficiency. If you don't want to make damage occur only once, make it occur at least at 0.5 second intervals (although I dislike that ide).



Spell uses a decent indexing method and works fine. Idea is also nice and could be useful. Just adjust the two just mentioned flaws and this spell is good to go!

Deuterium

[Aspard]

Ehm... what should I do to get this "damage based mana" back? Casted the spell about ten times and didn't get such an effect, wtf?

EDIT: Well, I looked at triggering and got the point. You should mention asap in the spell tooltip, that the mana is back only from units which has it at all!

[Foopad]

Originally Posted by Deuterium

Deuterium's Brief Review

1. This:

(Life of (Picked unit)) Greater than 0.46

Should be:

(Life of (Picked unit)) Greater than 0.41

2. Adjust the damage and special effects to occur once per enemy unit instead of having it occurring at 0.03 intervals and thus decreasing efficiency. If you don't want to make damage occur only once, make it occur at least at 0.5 second intervals (although I dislike that ide).

Deuterium

Thanks for the life tip :)

I would agree on the special effects part - I disagree on the damage part, the damage is essentiel for the mana stolen. Therefore if someone moves out of range or goes invurnable or anything the mana and damage done would not be correct.

I personally like the idea to do damage on intervals alot better. I've made it easy to see how much damage per level is actually done - I could have improved description.
@Aspard You should probably hit a unit with mana :)
I should change the description - I will.
Sincerely Foopad

[Deuterium]

Well as I said it was my personal opinion =)

Well then what you can do is run the effect only once, however run damage at 0.1 intervals (it's a bit senseless to use anything lower than that...)

[Aspard]

You'd better stop making reviews, friend, cause nothing will be approved till that xD

[Foopad]

Well I've changed the interval to 0.05 seconds - doesen't really make much of a difference, the ball is a little less smoother, nothing noticable though. The preformance is improved a bit though :). Thanks for the tip.
I've also changed the description abit and added a changelog.
Sincerely Foopad

[Deuterium]

Foopad :P no i didn't request to change periodic time... I asked to change damage intervals. Periodic time SHOULD stay .03 for the missile to move smoothly.

What you have to do is (this goes inside the trigger which is running at 0.03):

Set DAMAGETIMER[Index] = (DAMAGETIMER[Index] + 0.03)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

DAMAGETIMER[Index] Greater than or equal to DamageIntervalTime

Then - Actions

// Do the damage & create SFX
Set DAMAGETIMER[Index] = 0.00

Else - Actions

That way you'd have increased efficiency and less SFX spam... and preserve missile smoothness

Sorry for the misunderstanding :s

[Foopad]

Don't be sorry :).
That would make the spell rather odd? It would damage once or twice and the effects would come once or twice. The range of the spell would be ruined in my opinion - The range when done my way is a constant 500 around the orb, while in your way it's a point or two. C---0---0, where mine is a moving 00000000. Well I am going to keep it at that for the moment. I hope it is still approveable
Illustrations ftw!

[Deuterium]

Yes what you say make sense too :P
Well that at least make the SFX appear at lesser intervals:

Set SFXTimer[Index] = (SFXTimer[Index] + 0.03)
If (All Conditions are True) then do (Then Actions) else do (Else Actions)

If - Conditions

SFXTimer[Index] Greater than or equal to SFXIntervalTime

Then - Actions

// create SFX
Set SFXTimer[Index] = 0.00

Else - Actions

That way you'd still have your smooth damage, and no SFX spam... and you can put the periodic time back to 0.03

Just do that and you're good to go =)

[Foopad]

Okay, I'll do that :)
[Edit] I've done it, although I think the effects are bugging. Check it out, and check the code if you like. It seems really odd!

[Deuterium]

Ok here's the fixed version =)

Enjoy!

EDIT:
And effects look perfect now ;) with barely any fps decrease...

[Foopad]

Thank you Deuterium - it is perfect!

[Deuterium]

Well now just wait for Hanky or The_Reborn_Devil to approve this ;)