Cell Solar Kamehameha

[Moderator]

12th Dec 2015
IcemanBo: Too long as NeedsFix. Rejected.

22:38, 19th Jul 2014
BPower:
Currently this submission is far away from approval, because of multiple critical issues like waits and leaks.
You'll find very good advice and tipps in comment 4 (Thanks Tank-Commander)

 

[IcemanBo]

Please post your trigger set in description: http://www.hiveworkshop.com/forums/miscellaneous-tutorials-456/how-easily-post-triggers-163285/

 

[Ajijang2013]

The spell isn't MUI or MPI. You'd better to take some look on other kamehameha spells right here in the hiveworkshop.

 

[Tank-Commander]

Critique

All these spells are full of leaks, especially point leaks since they're never removed. There's also a total lack of configuration, which these spells should all have, additionally, there should be as few imports in a given map as possible, things unecessary like the anime models, should be removed

• Wait 0.50 seconds

You should never use TSA(Trigger Sleep Action, also know as waits) in submitted spell resources MUI Spells Using Artificial Waits explains how to avoid these

• Sound - Play kame_charge <gen>

Spells shouldn't really use sound functions, not without a configuration for selecting them and additional important instructions to go with it, anyway

• Unit - Pause Cell

Pausing units is poor form and should be avoided when possible

• Time - Every (0.01 / 2.00) seconds of game time

Nope, just nope. Use 0.03 or 0.03125 (if you want to be pedantic about it), nothing faster than that.

• Taiyoken
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to Taiyoken
  • Actions
    • Set TC = (Casting unit)
    • Unit - Create 2 Taiyoken for (Owner of TC) at (Position of TC) facing Default building facing degrees
    • Unit Group - Pick every unit in (Units owned by (Owner of TC) of type Taiyoken) and do (Actions)
      • Loop - Actions
        • Unit - Add a 5.00 second Generic expiration timer to (Picked unit)

This spell is object editor based other than that, and frankly isn't worth it, we only approve incredible-level object editor based spells, and even then it's unlikely to ever be approved

• Unit - Cause Cell to damage (Picked unit), dealing (400.00 x (Real((Level of Solar Kamehameha for Cell)))) damage of attack type Spells and damage type Normal

While it's nice this damage is triggered, it should really be in a configuration and not hard-coded

• Camera - Stop swaying/shaking the camera for (Owner of Cell)

Don't use functions which pertain to the game Camera in submitted spells, the rules specifically state no cinematic spells

There's also a tonne of not-at-all-MUI-or-MPI issues on that and you should take a look at a few tutorials before fixing these up to be in a usable state (I'd recommend using a linked list or dynamic indexing), another key thing to note is repetition of funcitons which don't really need to be there, your variables should be more generic and have prefixes to prevent overlap, and you shouldn't label the unit variable "Cell" as it's inappropriate for it's purpose.

That should cover most of the basic problems

Other

The spell isn't MUI or GUI. You'd better to take some look on other kamehameha spells right here in the hiveworkshop.

The spell isn't MUI or GUI.

MUI or GUI.

MUI or GUI.

Want to try that again?

 

[zv27]

The spell isn't MUI or GUI. You'd better to take some look on other kamehameha spells right here in the hiveworkshop.

The legend is born. muhahhaahha

 

[Wrda]

The spell isn't MUI or GUI. You'd better to take some look on other kamehameha spells right here in the hiveworkshop.

You've greatly improved my signature.

 

[gorillabull]

 

[chobibo]

Try to learn how to make MUI spells bro, then remake this spell. Don't worry, not everyone wants to mock you. Good luck.

 

[Daffa]

The spell isn't MUI or MPI. You'd better to take some look on other kamehameha spells right here in the hiveworkshop.

Fixed it for you.

---------------
P.S : we have 1(2?) approved Kamehameha spell in database, give us reason why this is better than the rest.

I assume Tank explains it very well.
I recommend read some tutorial about indexing and Hashtables.

 

[Deleted member 219079]

The spell isn't MUI or GUI. You'd better to take some look on other kamehameha spells right here in the hiveworkshop.

That actually took longer than I'd want to admit to understand the joke

 

[doomhammer99]

err post triggers pls

 

[hdm]

Am I the only who didn't understand the joke ?

 

[Arhowk]

Am I the only who didn't understand the joke ?

it was in gui. he meant to say mpi, mpi and gui are totally different. gui is the language it was built in and mpi means that different players can cast it at once

 

[jonhysone]

Guys it's really not MUI and GUI ! Why don't you believe him ? :'(

 

[rarigate]

Guys it's really not MUI and GUI ! Why don't you believe him ? :'(

Uhh, what the hell?

 

[Wrda]

^ Troller
On topic: You shouldn't post another kamehameha spell, we already have 5-6 of them, better check first before posting. (Its quite repetitive posting the same spell).
Look around for some tutorials about MUI. They will help you.

 

[Kazeon]

Other

Originally Posted by Ajijang2013
The spell isn't MUI or GUI. You'd better to take some look on other kamehameha spells right here in the hiveworkshop.

The spell isn't MUI or GUI.

MUI or GUI.

MUI or GUI.

Want to try that again?

lool. That's so funny man