Assassination

[Moderator]

IcemanBo:
Read again mentioned points.

BPower:
Demo map file size is unacceptable. Reduce it down to what is directly related to the spell.
You still have no configuration trigger. Check out approved resources for better understanding.

16:07, 5th Jul 2015
Maker:

• The test map is way too big, reduce unneeded imported files
• Remove the recover trigger, use dummy animation death time
  and death type "Does not decay" instead
• Don't pause the caster
• Don't do "Assa_Max Equal to 0" ten times per second
• You only need one dummy unit to cast Storm bolt on every unit
• The spell is not easily configurable, you could use a configuration trigger

 

[IcemanBo]

Hello.

This looks much better already as you go with indexing now,
but still there are critical things to mention.

Please read the http://www.hiveworkshop.com/forums/rules-information-710/spell-submission-rules-230362/.

Users have to be able to configure your spell to their liking.

^This means create config trigger. In this config trigger user should be able
to configurate all important aspects of the spell to his likes. Also for each level.
Do not put the config staff into the cast trigger. That's completly not wanted.

Spells and systems must have decent importing instructions

Also don't hardcode. That means don't write explicite values into your main code, when user could want to change it.
For example effects. Don't choose the effect YOU want, but let user decide it in config trigger.
Make as much as posible configurable, for example also damage and attack type.

Responses used more often should be stored into temporary variables to gain performance.
For example "LastCreated..t" is used very often? Store it into a varible and then work with the variable.

I have not tested your spell in game yet, but for periodical movements 0.03 is recommended as periodic event to achieve smooth visuals.

Your "remove unit" trigger is not deeded. Change the death type of the dummies to "does not raise/not decay" and it will be finde on death.

The check to turn off the periodic trigger should only happen onDeindex, not in each iteration of your loop.

Don't use PauseUnit for caster.

NeedsFix

 

[Chaosy]

1/5 is going a little overboard. I took a quick look, seems to be MUI, no major mistakes either. Big improvements since the last spells I saw by you.

edit: my bad, I should not have mentioned the rating. It's like begging for drama, and it was not meant to criticize you I was mostly surprised.

 

[IcemanBo]

Rating was done at first upload iirc. We don't re-evaluate rating after each update, but when approved for example, we will for sure.

 

[Chaosy]

Ah.

Anyway, my bad for bringing up the rating it's kinda pointless to do so. Sorry about that.

 

[IcemanBo]

But positive is you care about fairness.

 

[GywGod133]

- Create a very simple test map buddy. The high priority here is your spell not the test map

- And also remove those things that 'cuz of lag does not part of your spell

- In Trigger Loop

Unit - Create 1 Assa_Dummy for (Owner of Assa_Caster[Assa_Loop]) at Assa_PointR facing Assa_PointT
Change the Owner to Neutral Passive Player

Unit - Create 1 Assa_Dummy2 for (Owner of Assa_Caster[Assa_Loop]) at Assa_PointT facing Default building facing degrees
Change the Owner to Neutral Passive Player this Dummy Caster
And also in Object Editor,
change the DummyCaster's Stun Ability the Stats - Target Allowed (remove Enemy)

- This

Long

• Set Assa_GroupDMG = (Units within Assa_Area[Assa_Lvl[Assa_Loop]] of Assa_PointT matching ((((Matching unit) belongs to an enemy of (Owner of Assa_Caster[Assa_Loop])) Equal to True) and (((Matching unit) is alive) Equal to True)))

All conditions, put it in ITE (If Then Else)