Leaktester

[Ralle]

Hey guys,
Please take a look at this:
http://www.hiveworkshop.com/forums/apps.php?p=leaktester

I am mostly interested in errors and maps that are not readable.

 

[Xonok]

Note that it's not really comfortable to drag maps into the box for some. In my case, it's because I do not have a widescreen and thus, I keep my browser maximized.

EDIT: Tried to upload Bootybay and it still hasn't finished uploading.

 

[Ralle]

Does it seem stuck to you?

 

[Xonok]

Does it seem stuck to you?

It seems like it updated the text to say "Uploading" and then simply didn't do anything more.
I use windows XP.

 

[PurgeandFire]

Try refreshing and doing it again. That happened to me the first time I tried uploading a map.

 

[Xonok]

Uploading worked now, after one refresh. But now it gets stuck at parsing common.j
At first I thought it's because melee maps are lacking something.
As a test I loaded a non-melee that I've made myself, but it still doesn't get farther.

 

[Ralle]

It may take quite some time. My laptop does it in a few seconds, but it may take longer on older machines, no offence .

 

[Daffa]

According to Doomlord at Chat yesterday, he manages to test it till the end, but it misses some leaks on his map

EDIT :
What the? It says that there's a leak at local location on Line 137 (Location), but I nulled that location in line 140/141 and 141/142 with custom script.

 

[PurgeandFire]

According to Doomlord at Chat yesterday, he manages to test it till the end, but it misses some leaks on his map

EDIT :
What the? It says that there's a leak at local location on Line 137 (Location), but I nulled that location in line 140/141 and 141/142 with custom script.

You have to have "call RemoveLocation()". Nulling it won't necessarily fix the leak.

But anyway, I assume this is still being updated. I think Ralle's main concern right now is compatibility with maps--whether there are any errors that appear or whatever.

 

[Daffa]

^ I did call that function.

 

[Ralle]

Show me the code.
As the leaker cannot predict branches, this will not be shown as a leak:

local location x = Location(5, 5)
if false then
  call RemoveLocation(x)
endif

It will not know whether or not this branch was touched, so it assumes it was and judges it to be a non-leak.

 

[Daffa]

Hmm... I'll send it later.

EDIT :

• Storm Bolt Cast
  • Events
    • Unit - A unit Starts the effect of an ability
  • Conditions
    • (Ability being cast) Equal to (==) Storm Bolt
  • Actions
    • Custom script: local unit ST_Caster=GetSpellAbilityUnit()
    • Custom script: local unit ST_Target=GetSpellTargetUnit()
    • Custom script: local location ST_Point = Location( GetUnitX( udg_ST_Caster), GetUnitY( udg_ST_Caster))
    • Wait 0.50 seconds
    • Unit - Cause ST_Caster to damage circular area after 0.00 seconds of radius 305.00 at ST_Point, dealing (ST_Damage + ((Real((Level of Storm Bolt for ST_Caster))) x ST_Level)) damage of attack type Spells and damage type Lightning
    • Custom script: call RemoveLocation(udg_ST_Point)
    • Custom script: set ST_Point=null
    • Custom script: set ST_Caster=null
    • Custom script: set ST_Target=null

I did nulled and remove it.

 

[Ralle]

Yep this leaks. You are clearing a none local variable.

 

[rulerofiron99]

Nice tool, works well and quickly.

Results layout is good.

Aesthetic suggestions:
- Progress bar while checking leaks
- The + symbol next to each expandable type.

Should also print the line that the leak was found in.

 

[Daffa]

@Ralle
Thanks, I was reckless I guess >.>

Oh yeah, it's hard to spot which triggers leaks for GUI users sometimes (if they never touch JASS), also, add a reason why it leaks (ex. Point : No Variable Set, Point : Missing Location Removal)

 

[Ralle]

Every time something leaks it is because it was not removed. It already tells you the type of the leak.

 

[neo_sluf]

i will gonna try this.. hope it will detect every leak possible..

 

[neo_sluf]

Sorry for the double post..


I tried the program.. it is very fast.. using google chrome!!..

Anyway i would like to suggest..

-Pls. put what type of leaks are found..
- And give some suggestion on how to remove leaks like use call RemoveLocation(udg_variable) for this leak ... etc..

GOOD JOB ON THIS CHIEF!!

 

[Daffa]

@Ralle
I see

@Neo
Y U NO use Edit button.

 

[mckill2009]

it has limited functionality, it only detects locations and effects, cant detect rect leaks...but anyway maybe this is just a test?...

also i had this:

Error: WARNING: Function missing: UnitAlive

 

[Ralle]

Where is UnitAlive? Is it an old map? Is it RoC?

Do rects leak? Are you certain that it does not detect this?

 

[mckill2009]

UnitAlive is a native in the common.ai, which I included in my map...

Anything that holds a handle leaks, rect is one of those...

 

[Magtheridon96]

Ralle, you may want to add these:

native GetPlayerUnitTypeCount takes player p, integer unitid returns integer
native GetUnitGoldCost takes integer unitid returns integer
native GetUnitWoodCost takes integer unitid returns integer
native GetUnitBuildTime takes integer unitid returns integer

native CreepsOnMap takes nothing returns boolean
native UnitAlive takes unit id returns boolean

These are the only common.ai natives that work in JASS war3map.j code.

 

[Rui]

That is exclusive to AI right? I knew there was a GetUnitGold/WoodCost() somewhere and then I thought I had been imagining things. It can't be used in the Trigger Editor can it?

 

[mckill2009]

All of it can be used in the trigger editor except for CreepsOnMap, as I've tested it before, not working...

 

[Ralle]

I will probably parse common.ai then. That seems better. Thanks for this, I will add this soon.

 

[Chaosy]

So this finds all leaks in a map?

Will likely test it tomarrow

 

[Ralle]

It does not. It finds some leaks.

 

[DivineLight]

is it better to finds the leaks manually or using this?

 

[BloodDrunk]

is it better to finds the leaks manually or using this?

well of course manually, but this can speedup the process of finding leaks alot and Ralle already stated it finds only some leaks

 

[DivineLight]

okay then.. just wondering

 

[Ralle]

My hope was that this would help people find leaks and help them learn about leaks too.

 

[Rui]

Being the primary Wc3 site, of course this is an awesome addition xP

 

[DivineLight]

xD
but that's right
hive is the most active wc3 site..

 

[Ralle]

UnitAlive is a native in the common.ai, which I included in my map...

Anything that holds a handle leaks, rect is one of those...

It now also parses common.ai. Please test it