GetUnitX/Y vs GetWidgetX/Y

[BPower]

Lately many users started replacing GetUnitX/Y with GetWidgetX/Y.

The argument was handle > agent > widget whereas handle > agent > widget > unit. The first impression may be GetUnitX is faster than GetWidgetX, but can someone prove this assumption?

If I remember correctly, old benchmarking showed GetUnitX is faster than GetWidgetX.

 

[nhocklanhox6]

unit -> widget -> agent -> handle

Just test the benchmark, and you will see GetWidget faster than GetUnit.

 

[BPower]

Credits

Bribe for pointing out that GetUnitX faster than GetWidgetX faster than GetItemX

Just found this posted 2010 here : http://www.hiveworkshop.com/forums/jass-resources-412/snippet-item-position-184566/

 

[nhocklanhox6]

Here is the key (Thank bowser499 for that key)

 type unit extends widget 
type widget extends agent 
type agent extends handle

Unit standing behind Widget and extends Widget => Widget faster than Unit

 

[WaterKnight]

How do you even want to know if they have the same implementation?

GetUnitX is slightly faster than GetWidgetX for me (on 15mio iterations, latter requires 13% more time).

 

[nhocklanhox6]

Messages of Bowser

GetWidgetX/Y is faster than GetUnitX/Y. It was benchmarked by me multiple times. The key is here:
Jass:

type unit extends widget
type widget extends agent
type agent extends handle

The widget type is one level higher than unit so it will execute faster.

Use can test the benchmark to see Frames time and minmaxavg too.

 

[BPower]

@nhocklanhox6: Benchmark it anything else is just theoretical and could be totally wrong.

Edit: Can't do it myself, since I have no Wc3 available at the moment.

 

[nhocklanhox6]

I trust the hardcore of the computer .

EDIT:
And the one thing i trust Widget faster than Unit is that key , as bowser said "The widget type is one level higher than unit so it will execute faster." ( Unit standing behind Widget and extends Widget. )

@hoden: It's fine , i just said anything i think it's right.

 

[bowser499]

function Test1 takes nothing returns nothing
      local integer i = 0
      local unit u = CreateUnit(Player(0),'hfoo',0.,0.,0.)
        
      loop
          set i = i + 1
              call GetUnitX(u)
              call BJDebugMsg(I2S(i))
      endloop
        
      set u = null
endfunction

function Test2 takes nothing returns nothing
      local integer i = 0
      local unit u = CreateUnit(Player(0),'hfoo',0.,0.,0.)
        
      loop
          set i = i + 1
              call GetWidgetX(u)
              call BJDebugMsg(I2S(i))
      endloop
        
      set u = null
endfunction

Run both of them. Greater number of iterations means more fast function.

 

[WaterKnight]

Run both of them. Greater number of iterations means more fast function.

Why? The amount of jass instructions is limited per thread, not the engine nor execution time. Both of your functions yield the same number because it's jass-execution-syntactically the same.

 

[bowser499]

WaterKnight, lolz. Go with some screenshots please.

 

[WaterKnight]

Which show what? Both exit already after the 811th message because BJDebugMsg takes a great share with its own loop.

 

[Bribe]

WaterKnight, lolz. Go with some screenshots please.

I recommend you produce screenshots since you are the one making claims outside of the standard.

 

[Malhorne]

I though that GetWidgetX is faster since it is extending directly ...

 

[bowser499]

WidgetX/Y are generalized.

 

[Malhorne]

Yes but in the common.j we can see widget extending to handle directly whereas unit extend widget.

 

[Bribe]

There is no obvious reason why GetUnitX/Y are faster, and why GetItemX/Y are slower. It has to do with how WC3 processes the bytecode internally which is of course a mystery to all who are not looking at the proprietary source code which is hidden to all eyes except for Blizzard internal, and probably no one currently there even understands that source code because they fired all those guys.

 

[moyackx]

if you want to make a function that receives as arguments units and items, then use GetWidgetX/Y, if you want functions that only manage units, then unit GetUnitX/Y

Period

 

[muzzel]

Unit standing behind Widget and extends Widget => Widget faster than Unit

I though that GetWidgetX is faster since it is extending directly ...

Are these just assumptions or do you actually know how the internal type hierarchy influences the execution speed of the natives (in this case i expect references)?

 

[chobibo]

Test!

Where's the screenshot?
EDIT:
Tested using this:

script

globals
    unit U
    integer N=0
    integer M=0
    constant timer t=CreateTimer()
    constant timer t1=CreateTimer()
    constant timer t2=CreateTimer()
endglobals

function a takes nothing returns nothing
    loop
        call GetUnitX(U)
        set N=N+1
    endloop
endfunction

function b takes nothing returns nothing
    loop
        call GetWidgetX(U)
        set M=M+1
    endloop
endfunction

function display takes nothing returns nothing
    local string msg="GetUnitX: "+I2S(N)+" ** GetWidgetX: "+I2S(M)
    call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60.00,msg)
endfunction

function Stato takes nothing returns nothing
    call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60.00,"Test Stato!")
    call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60.00,"GetUnitX started!")
    call TimerStart(t1,0.1,false,function a)
    call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60.00,"GetWidgetX started!")
    call TimerStart(t2,0.2,false,function b)
    call TimerStart(t,1.0,false,function display)
    call DisplayTimedTextToPlayer(GetLocalPlayer(),0,0,60.00,"Test End!")
endfunction



//===========================================================================
function InitTrig_Init takes nothing returns nothing
    set U=CreateUnit(Player(0),'hfoo',0,0,0)
    call TimerStart(t,1.00,false,function Stato)
endfunction

Result: both managed to loop 30,000 times

Image

Conclusion: Loops aren't good benchmarking tools.

Run both of them. Greater number of iterations means more fast function.

Sorry, but you were wrong.

 

[WaterKnight]

if you want to make a function that receives as arguments units and items, then use GetWidgetX/Y, if you want functions that only manage units, then unit GetUnitX/Y

Period

There is GetItemX/Y (as well as GetDestructableX/Y) and it makes little sense to build shared functions.

 

[chobibo]

The developers left a lot of junk when they released the editor. Oh, and the loop argument is no longer valid.

 

[WaterKnight]

What you should do though is using GetWidgetLife(u) instead of GetUnitState(u, UNIT_STATE_LIFE) because it needs to pass one less parameter, does not have to read the variable/constant and not switch internally. But yeah, those are peanuts.

 

[T. D. W.]

i think this this place is, um, almost a battlefield, Mago and Almia are missing :3

 

[Malhorne]

Yes we need someone that can show us what is the faster ....
I think we'll have to open the source code :/

 

[chobibo]

Someone could use the RtC stopwatch, but that requires 1.24.

 

[Malhorne]

Yes >_< ....

 

[WaterKnight]

I did as written here:

http://www.hiveworkshop.com/forums/lab-715/preloadgenstart-241159/

function a takes nothing returns nothing
    local integer i=1000
    loop
        exitwhen (i<1)
        call GetUnitX(udg_u)
        set i=i-1
    endloop
endfunction

function bla takes nothing returns nothing
    local integer i=15000
    
    
    local trigger t=CreateTrigger()
    call TriggerAddCondition(t, Condition(function a))
    
    set udg_u=CreateUnit(Player(0), 'hpea', 0, 0, 0)

    call PreloadGenStart()
    
    loop
        exitwhen (i<1)
        call TriggerEvaluate(t)
        set i=i-1
    endloop
    
    call PreloadGenEnd("benchmark.txt")
    
    call BJDebugMsg("ende")
endfunction

One time with GetUnitX, one time with GetWidgetX, one time without anything between in order to subtract the framework expense. The results are pretty stable if you do not do anything else in background.

According to that and assuming it's linear, it's 974026 times call GetWidgetX(udg_u) per second to 1102941 times call GetUnitX(udg_u) per second for me.

 

[TriggerHappy]

GetUnitX is faster according to my tests.

 

[Malhorne]

Hum....
What do we conclude XD ?
Can you show us what tests ?

 

[TriggerHappy]

Check my benchmarking thread.

getunitx was ~5-7% faster

 

[Malhorne]

Can we have a link ?

 

[Maker]

library leakTest1 initializer onInit
    globals
        private timer t = CreateTimer()
        private constant integer dummies = 1
        private constant integer events = 50
        private integer c = 0
        private trigger acquire = CreateTrigger()
    endglobals
    
    private function acquireItem takes nothing returns boolean
        //local unit u
        local integer i = events
        loop
            /*
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            call GetWidgetX(udg_u)
            */
            
            
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            call GetUnitX(udg_u)
            
            
            exitwhen i == 0
            set i = i - 1
        endloop
        //set u = null
        return false
    endfunction

    private function leaks takes nothing returns nothing
        local integer i = dummies
        
        loop
            exitwhen i == 0
            call KillUnit(CreateUnit(Player(0), 'hfoo', 0, 0, 0))
            set c = c + 1
            set i = i - 1
        endloop
    endfunction
    
    private function pauseResume takes nothing returns nothing
        if ModuloInteger(GetTriggerExecCount(GetTriggeringTrigger()) , 2) == 1 then
            call BJDebugMsg("started")
            //call TimerStart(t, 0.01, true, function leaks)
            call TimerStart(t, 0.001, true, function acquireItem)
        else
            call BJDebugMsg("paused, " + "dummies created: " + I2S(c))
            call PauseTimer(t)
        endif
    endfunction

    private function onInit takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterPlayerEvent(t, Player(0), EVENT_PLAYER_END_CINEMATIC)
        call TriggerAddAction(t, function pauseResume)
        call TriggerRegisterAnyUnitEventBJ(acquire, EVENT_PLAYER_UNIT_DEATH)
        call TriggerAddCondition(acquire, function acquireItem)
    endfunction
endlibrary

My max FPS is limited to 60. With GetWidgetX, the FPS was 43-48. With GetUnitX, constant 60. Measured with the in-game /fps command. The unit was patrolling.

 

[T. D. W.]

So GetUnitX/Y is faster, more efficient, changing the code right now xD

 

[chobibo]

@Malhorne TriggerHappy's benchmark thread.

 

[Malhorne]

Ah sorry for such lazyness :/
Can't see it need RtC and 1.24 ^^'

EDIT :
Thanks Maker

 

[Troll-Brain]

Without any benchmark it's pretty obvious, simply because GetWidgetX/Y has probably to figure first what type of widget it is and then read the correct information about it.

 

[T. D. W.]

That was also my thought after the benchmarks got out

 

[Troll-Brain]

And that should be the same for all "generic" against "specific", such as GetTriggerUnit VS GetDyingUnit, and so one.

 

[Malhorne]

But GetTriggerUnit is the faster no ?

 

[Troll-Brain]

Never tested, but no that should be the slowest.

 

[Malhorne]

I think we should test but if I remember well someone said to me to prefer GetTriggerUnit ...
We need someone -> Maker xD ?

 

[Maker]

This changes the owner of a unit and uses an event to detect the ownership change

library leakTest1 initializer onInit
    globals
        private timer t = CreateTimer()
        private constant integer dummies = 1
        private constant integer events = 350
        private integer c = 0
        private trigger acquire = CreateTrigger()
        private unit hero
        private boolean boo = false
    endglobals
    
    private function acquireItem takes nothing returns boolean
        local unit u
        local integer i = events
        loop
            
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            set u = GetChangingUnit()
            
            exitwhen i == 0
            set i = i - 1
        endloop
        call ReviveHero(hero, 0, 0, false)
        set u = null
        return false
    endfunction

    private function leaks takes nothing returns nothing
        set boo = not boo
        if boo then
            call SetUnitOwner(hero, Player(0), false)
        else
            call SetUnitOwner(hero, Player(1), false)
        endif
        set c = c + 1
    endfunction
    
    private function pauseResume takes nothing returns nothing
        if ModuloInteger(GetTriggerExecCount(GetTriggeringTrigger()) , 2) == 1 then
            call BJDebugMsg("started")
            call TimerStart(t, 0.005, true, function leaks)
            //call TimerStart(t, 0.001, true, function acquireItem)
        else
            call BJDebugMsg("paused, " + "dummies created: " + I2S(c))
            call PauseTimer(t)
        endif
    endfunction

    private function onInit takes nothing returns nothing
        local trigger t = CreateTrigger()
        call TriggerRegisterPlayerEvent(t, Player(0), EVENT_PLAYER_END_CINEMATIC)
        call TriggerAddAction(t, function pauseResume)
        call TriggerRegisterPlayerUnitEvent(acquire, Player(0), EVENT_PLAYER_UNIT_CHANGE_OWNER, null)
        call TriggerAddCondition(acquire, function acquireItem)
        set hero = CreateUnit(Player(0), 'Hpal', 0, 0, 0)
    endfunction
endlibrary

GetTriggerUnit -> constant 60 fps
GetChangingUnit -> ~23 fps

I would assume the same goes for dying unit, might test it later

 

[WaterKnight]

with owner change event:
GetChangingUnit -> 11.8 seconds/15mio calls
GetTriggerUnit -> 7.9 seconds/15mio calls

with unit's death event:
GetDyingUnit -> 7.5 seconds/15mio calls
GetTriggerUnit -> 7.9 seconds/15mio calls
GetKillingUnit -> 11.3 seconds/15mio calls

test code

function a takes nothing returns nothing
    local integer i=1000

    loop
        exitwhen (i<1)
        //call GetWidgetX(udg_u)
        call GetKillingUnit()
        set i=i-1
    endloop
endfunction

function death takes nothing returns nothing
    local integer i=15000
    
    local trigger t=CreateTrigger()
    call TriggerAddCondition(t, Condition(function a))

    call PreloadGenStart()

    loop
        exitwhen (i<1)
        call TriggerEvaluate(t)
        set i=i-1
    endloop
    
    call PreloadGenEnd("benchmark.txt")
    
    call BJDebugMsg("ende")
endfunction

function b takes nothing returns nothing    
    set udg_u=CreateUnit(Player(0), 'hpea', 0, 0, 0)
    
    call KillUnit(udg_u)
endfunction

//===========================================================================
function InitTrig_Nahkampf_Initialisierung takes nothing returns nothing
    set gg_trg_Nahkampf_Initialisierung = CreateTrigger(  )
    call TriggerRegisterPlayerEventEndCinematic( gg_trg_Nahkampf_Initialisierung, Player(0) )
    call TriggerAddAction( gg_trg_Nahkampf_Initialisierung, function b )
    
    set udg_ownerchangetrig=CreateTrigger()
    call TriggerRegisterPlayerUnitEvent(udg_ownerchangetrig, Player(0), EVENT_PLAYER_UNIT_DEATH, null)
    call TriggerAddAction( udg_ownerchangetrig, function death )
endfunction

the code for unit changing owner was analogue.

Ps: GetTriggerUnit is not recommended for its speed advantage but for its universality.

 

[Malhorne]

Yes but it seems to be kinda fast too

 

[Troll-Brain]

It should be called JAWS instead of JASS then, Just An other Weird Script.

Unless i'm missing something these results don't make sense.

 

[Malhorne]

They don't make sense at all ^^

 

[moyackx]

They don't make sense at all ^^

This thread is tending to not making sense at all

 

[Troll-Brain]

But speculations are fun.

 

[Malhorne]

Yes but at least we know what the fastest