[Snippet] Thread

[Magtheridon96]

Tested.
Working when you select 12 units.
Approved.

[Nestharus]

Added thread.wait() and SynchronizeThread()

[Magtheridon96]

Jass:

*   */uses/*
*
*       *  Alloc  *         hiveworkshop.com/forums/jass-resources-412/snippet-alloc-192348/
*       */ WorldBounds /*   hiveworkshop.com/forums/jass-resources-412/snippet-worldbounds-180494/

I think we both know what's wrong here.

[Nestharus]

???

Absolutely nothing, for vex's vjass, modules that don't have keywords do not have to be in a library to be used. Only cohadar's does not allow this, so as a result, you can comment out the library usage : ).

This works in vex's

Jass:

struct Test extends array
    implement I
endstruct
module I
endmodule

[Magtheridon96]

But there's no harm in keeping it, I mean, currently, it could cause some confusion (Some people might think you that you commented out the Alloc part because you don't require it in there)

[Troll-Brain]

But if he removes this fugly comment usage, it would make sense and he wouldn't bitching Cohadar's jasshelper.
It's just too much for him.

[Nestharus]

Fixed a problem with unsync'd code that creates threads ;o. The unit was getting created/selected for one machine before another machine, which was causing syncing problems.

[Nestharus]

Updated

now synchronizes all 12 players rather than just waiting for the first player to send sync request ; O.

[Troll-Brain]

However as said i don't what happens if a player don't load completely the game before leaving.

[Nestharus]

It'll still work just fine

edit
no wait, it won't ;o

hm...

i'm going to have to update the sync count in both the synced operator and the selection event

also... for the selection event, I really don't want it to fire whenever any unit is selected, but I've no choice >.<.

[Troll-Brain]

I thought about something else, if a such leaving player trigger the player leave event then it's easy.

[Nestharus]

no, because there are multiple thread instances. Would have to iterate over every thread ; \.

[Troll-Brain]

No, at init you check how many players there are.
And when a player leaves you just decrease this number.

And btw have you not already done something similar to handle players "PlayerUtils" something like that ?

[Nestharus]

That won't work because a leaving player may/may not have run a selection event (possible early fire)

Also, the leaving player may be the last one to run the selection event, in which case the synced var is never updated.

[Troll-Brain]

Originally Posted by Nestharus

That won't work because a leaving player may/may not have run a selection event (possible early fire)

Also, the leaving player may be the last one to run the selection event, in which case the synced var is never updated.

My assumption is that the leaving player won't trigger the select event but trigger the player leave event.
If it trigger the player event then the code in the current version is fine.