[vJASS][System] Unit Properties

[vercas]

Oh my god... This is one step from being awesome!

Does it show like
"Min - Max + Bonus"
The damage?
It's all I care about.
(I can't test it here!)

[azlier]

This is excellent work. I'm going to approve this. It's deserved approval for quite a while.

[enyeas]

What would be a list of steps to use this in a map? I have:

1. Saved the LUA file in map directory
2. Put the code in a blank text trigger
3. Uncommented object merger line
4. Saved successfully, including object merger
5. Commented out object merger line
6. Made a function to put a unit in the system:

call CreateUnitProperties(hero)  //hero being a unit variable holding a hero

7. Tried modifying the units properties:

call UnitModifyArmor(hero, 100)

But this does not work, perhaps I am missing something simple?

[Viikuna]

Remember to check that you have all those bonus abilities in object editor, that the lua script actually worked.

You can also add some temporary call BJDebugMsg( " word " ) -calls to the system code to find out where the code stops running, if it stops running.

[enyeas]

Ah, I was unaware that it would actually put the abilities in the ability editor. Thought it just kinda put it in the map file. In that case, no, the LUA does not import abilities. This is also the case with the other system I tried. I am using newgen, but is there something else i need to enable for the LUA to work?

Thanks

[YourNameHere]

Uncomment the lines so you have to save, but don't save. Close the map and click yes to save, after that load it again and you should see the abilities in the OE.

[enyeas]

thanks, that worked :)

[Berb]

There are a lot of systems now-a-days that use a function GetUnitId , perhaps it should be privatized?

[azlier]

Originally Posted by Berbanog

There are a lot of systems now-a-days that use a function GetUnitId , perhaps it should be privatized?

This one is correct. Especially unit indexing systems use GetUnitId because some fool decided that it should be the standard over GetUnitIndex.

[Viikuna]

If you read the comments, you see that its just a wrapper, which can be replaced with any unit indexing or data attachment system.

It should probably be made to require AutoIndex or something, but then again, its not a big job to edit UP code a bit and make it work so.





Also, since Cassiel posted this here just for those who already use the system to get the code from somewhere, I think it doesnt really need any updating, unless he releases that UP2 he mentioned in the first page of this thread.


So, currently its probably the best to just edit the system code by yourself and hope that this new UnitProperties will be realeased someday.

[Fundo!]

Could you make a template using your system that when a unit buys an item, +damage and +stats are added to that unit, and when the unit loses/does not have that item again restore his stats to the way they were before the item? Would greatly help :)

[Berb]

Knowing Cassiel I doubt that will happen.

[HyperActive]

You just detect when a unit acquires an item and when a unit drops an item. Then you search for what that item is, and add (or remove) thee bonuses it gives. It's rather simple, maybe a little annoying using many if conditions while searching for the item id.

Example

private function onItemPicked takes nothing returns nothing
local integer it = GetItemTypeId(GetManipulatedItem())
local unit u = GetTriggerUnit()
if it==RING_OF_REGENERATION_ID then
call UnitModifyLifeRegen(u, 2.0)
elseif it==SOBY_MASK_ID then
...
...
...
endif
endfunction

private function onItemDroped takes nothing returns nothing
local integer it = GetItemTypeId(GetManipulatedItem())
local unit u = GetTriggerUnit()
if it==RING_OF_REGENERATION_ID then
call UnitModifyLifeRegen(u, -2.0)
elseif it==SOBY_MASK_ID then
...
...
...
endif
endfunction

private function Init takes nothing returns nothing
call TriggerRegisterAnyUnitEventBJ(Trigger1, EVENT_PLAYER_UNIT_PICKUP_ITEM)
call TriggerAddAction(Trigger1, function onItemPicked)
call TriggerRegisterAnyUnitEventBJ(Trigger2, EVENT_PLAYER_UNIT_DROP_ITEM)
call TriggerAddAction(Trigger2, function onItemDroped)
endfunction

[Viikuna]

You should probably write some BonusMod like thingy that gives you a bonus parent type, that contaijns all of those properties. It could contain those if then else thingies for modifying the correct property, and so allow you to just attach this bonus instance to item, and make all items work with same onPickup and onDrop -triggers that just get the attached bonus struct and add bonuses from it to your unit.

[yatyfornetreg]

WICKED!!! yet i need some time to read it... thanks anyway.