[System]PT- Player Tracking

[Element of Water]

Yeah. That inlines. But not if you have debug mode on :P.

[Nestharus]

woops

Phase 1: import/novjass/delimited comments
Phase 2: text macros
Phase 3: Zinc
Phase 4: Libraries
Phase 5: Static ifs
Phase 6: Modules
Phase 7: Structs and many other things
Phase 8: PJass
Phase 9: Shadowhelper
Phase 10: PJass
Phase 11: Optimization (inline)

no wonder ^_^... I was checking via an error and optimization is done on the last phase so the inlining wouldn't have shown up ;o.

[MapperMalte]

Well, I didn't have debug mode on in my test. It would've been displayed.

[Element of Water]

You can look at the generated map script by going to

<Your NewGen Installation>\logs\outputWar3Map.j

[Nestharus]

Originally Posted by Element of Water

You can look at the generated map script by going to

<Your NewGen Installation>\logs\outputWar3Map.j

I know how to look at generated map script : p. I actually looked at map script and went, oh it inlines.. that means it does a dif order. From there I proceeded to Zinc manual cuz I knew the order was somewhere in there, and lo and behold there it was : o. Optimization is done last : D.

I always just use MPQ Editor since it takes me one second as MPQ Editor already points to all the right places ;p.


Btw, cjass updated to 1.3 : ). Sevion was running into syntax errors, I investigated and found a mistake due to a one liner definition that was set up with multi line method (yea.. cjass needs to fix that bug).

Changed it to one liner definition to fix the issue and now it works : ).

Thank you sevion for notifying me ^_^.

[azlier]

The benchmarks on TheHelper were broken. MapperMalte's benchmark is broken. Each benchmark needs to be done in separate thread within the same environments.

[Nestharus]

Hence the 5 or 6 different results thus far -.-

Oh 1.4 cjass up

Thank you Sevion for noticing another bug, aka the map wouldn't run : p

[MapperMalte]

My benchmark was not broken.

[Nestharus]

Originally Posted by MapperMalte

My benchmark was not broken.

you made mistakes too malte

function calls
use of strings

I don't think you used loops within the actual benchmarks, so that's one thing you did right : ). I don't want to open the map to find out because opening a map is a serious pain for me ><

So yea.. you had your mistakes too : ). You have no idea what strings do to running code ;o


The best method was to run a series of benchmarks and add them up, each benchmark maybe taking 10 results all exact operations with 0 extra calls. The loop would run outside of the benchmarking so that each operation was the exact system running : ). No strings until after the benchmarking took place and only one benchmark per run of the map as a previous benchmark could screw up results for following benchmarks. The computer has to be in the exact same state for each benchmark (making this entire effort futile ><).

[azlier]

Yes it was. Look here.

call Test.Start("PT","GetPlayer")
    call GetPlayer(0)
call Test.End()

call Test.Start("Native","Player")
    call Player(0)
call Test.End()

First flaw: those are not in separate functions called via TriggerExecute. Which means you can get weird results.

Second flaw: you call Player and GetPlayer, which means GetPlayer cannot inline like it should. So, GetPlayer should be even faster than your benchmark says it is.

[Nestharus]

Approved results place GetPlayer at 33.27% faster than Player()

[MapperMalte]

Originally Posted by azlier

Yes it was. Look here.

call Test.Start("PT","GetPlayer")
    call GetPlayer(0)
call Test.End()

call Test.Start("Native","Player")
    call Player(0)
call Test.End()

First flaw: those are not in separate functions called via TriggerExecute. Which means you can get weird results.

Second flaw: you call Player and GetPlayer, which means GetPlayer cannot inline like it should. So, GetPlayer should be even faster than your benchmark says it is.

Please read!
I directly inlined the GetPlayer function and the test.Start is just a synonym for StopWatchMark()

[Element of Water]

Er, no, that's not inlined. How the hell is that meant to inline? You should do set p = GetPlayer(0) / Player(0).

[YourNameHere]

Originally Posted by MapperMalte

Please read!
I directly inlined the GetPlayer function and the test.Start is just a synonym for StopWatchMark()

To what should inline that? Use your common sense.

[MapperMalte]

I inlined it by hand.