[System]PT- Player Tracking

[Nestharus]

Found a bug in this ; o. It caused leaving players to not be registered except for Player 0. It was 1 line fix.

Increased the ini loop speed, so it should be faster.

Benchmark code to compare old method and new method of slot check

include "cj_types.j"
include "cj_typesEx.j"
include "cj_print.j"
include "cj_types_priv.j"  
include "cj_typesEx_priv.j"
include "cj_order.j"  
include "cj_antibj_base.j"

scope Demo initializer Initialization {
    trigger t = CreateTrigger()
    event e = TriggerRegisterTimerEvent(t, 0, false)
    int sw, i = 5000; float mark
    
    bool Test() {
        sw = StopWatchCreate()
        do {
            if GetPlayerTeam(Player(0)) != -1 {} //.007
            //if GetPlayerSlotState(Player(0)) == PLAYER_SLOT_STATE_PLAYING {} //.011
        } whilenot --i == 0
        mark = StopWatchMark(sw)
        StopWatchDestroy(sw)
        printf(R2S(mark))
        return false
    }
    
    void Initialization() {
        TriggerAddCondition(t, Condition(function Test))
    }
}

Player 4 left.
Player count is 5.
Highest Player number is 6.

This wasn't working right because the trigger wasn't firing ^_^. It should be ok now ; p.

If player 4 leaves
Player count is 5

it'll go from this-

1 2 3 4 5 6

to this

1 2 3 6 5

4 is removed and the last player is put in it's place. This is why you can always loop through all the current players ^_^.

[Nestharus]

PlayerTracker 6.0 vJASS is up! : D

Edit
PlayerTracker 1.0 cJASS is up! : D

[MapperMalte]

function GetPlayer takes integer i returns player
Returns a player given an id. Exactly like the Player() native, but
slightly faster.

Wrong.
Proof:

[YourNameHere]

Maybe show us your whole testing code before claiming any proof?
Real benchmarks should use StopWatch and not some systems coded within the World Editor.

[MapperMalte]

This uses StopWatch.

Here:

scope Tests initializer SetUp

    globals
        private HandleTable Data
    endglobals
    
private function test takes nothing returns nothing
    local timer t
    local integer i
    call TestHelper.NextInstance()

        if TestHelper.IsFinished() then
            call PauseTimer(GetExpiredTimer())
            call DestroyTimer(GetExpiredTimer())
            call Test.Compare()
            //call Test.createTable()
            return
        endif
    
        call Test.Start("PT","GetPlayer")
            call GetPlayer(0)
        call Test.End()
        
        call Test.Start("Native","Player")
            call Player(0)
        call Test.End()

endfunction

    function TestSC takes nothing returns nothing
        call TestHelper.SetTest(170,170)
        call TimerStart(CreateTimer(),0.,true,function test)
    endfunction
    
    private function SetUp takes nothing returns nothing
        set Data = HandleTable.create()
        call Test.Declare("PT")
        call Test.Declare("Native")
    endfunction

endscope

[Element of Water]

I think a link to TestHelper is required.

[MapperMalte]

testmap attached.

[Element of Water]

Yeah... that system is a bit overkill don't you think? But whatever, it seems to work as described for the purposes of testing speeds.

[Nestharus]

Actually this stuff was benchmarked on TheHelper too and there were 3 different results, none of which are what you got -.-.

Result 1: Array is 33% faster
Result 2: The same or virtually the same
Result 3: Array is faster 7 out of 10 times


What we concluded was that in general, the array method is "slightly" better, but benchmarking tests are virtually inconclusive due to the nature of the JASS language : ).

For example, strings will screw up your results... etc.

This stuff was tested thoroughly and went through 12+ pages of debate


Now... for me it's not surprising that your results were way off base in regards to everyone else's. We all coded our stuff very specifically, inlined everything, and made it as tight as possible. You didn't.

Now it's either that or wc3 has had some major changes through the patches since these tests were done (1.24a I think).

[MapperMalte]

It's your tests that failed.
I just used your function. If it's not inline friendly - not my problem.
And I ran the test 150*150 times.

[Nestharus]

It's inline friendly -.-

[MapperMalte]

Ok.
I have redone the test.
Player Tracking is 5% faster than the native
Here is the code I used:

call Test.Start("PT","GetPlayer")
    set p = allPlayers[0]
call Test.End()

call Test.Start("Native","Player")
    set p = Player(0)
call Test.End()

You can place the screen in the first post if you want to.

[Nestharus]

Ok.
I have redone the test.
Player Tracking is 5% faster than the native
Here is the code I used:

I already knew that -.-

[Element of Water]

Originally Posted by Nestharus

It's inline friendly -.-

vjass just fails now... I haven't seen it inline anything since like 1 version before Zinc...


I guess we wait until Vexorian fixes inlining or we can move to cJASS definitions (which will probably never happen) since they never let you down.

This isn't even doing inline-

call GetComputerCount()

And that is just this

constant function GetComputerCount takes nothing returns integer
    return computerCount
endfunction

Inliner is broken atm...

So yea, all code from jasshelper going to be extra slower until vex fixes

But go ahead and continue to blame it on me Malte. I know you love that.

Lol. Of course that's not going to inline. You can't just call a variable. If it did inline it'd end up as, simply,

computerCount

which is obviously a syntax error.

[Nestharus]

well, I mean you get the point woops ><.

sec

// scope Test begins
    function Test__hi takes nothing returns nothing
        local integer p= GetComputerCount()
        a()
    endfunction
// scope Test ends

there, happy? ;p